mirror of
https://github.com/mumble-voip/mumble.git
synced 2026-03-03 00:46:56 -05:00
Release 1.4.230 source archives do not include required 3rd party submodules #2371
Labels
No labels
GlobalShortcuts
Hacktoberfest
accessibility
acl
asio
audio
bonjour
bsd
bug
build
certificate
ci
client
code
documentation
external-bug
feature-request
gRPC
github
good first issue
help wanted
help-needed
ice
installer
linux
macOS
needs-ckeck-with-latest-version
needs-more-input
overlay
positional audio
priority/P0 - Blocker
priority/P1 - Critical
priority/P2 - Important
priority/P3 - Somewhat important
priority/P4 - Low
public-server-registration
qt
recording
release-management
server
stale-no-response
stale-support
support
task
test
theme
translation
triage
ui
windows
wontfix
x64
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mumble-mumble-voip#2371
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dexgs on GitHub (Jan 17, 2022).
The issue
Trying to build the new release using the given source archives fails because the source directories for celt, rnnoise, etc. are all empty.
Mumble version
1.4.230
Mumble component
Both
OS
Linux
Additional information
No response
@Krzmbrzl commented on GitHub (Jan 17, 2022):
Which source archives? The ones from GitHub? These never contain submodules (as I have been told very recently) 👀
@dexgs commented on GitHub (Jan 17, 2022):
Right, sorry if I'm jumping the gun, but for previous releases, the release on GitHub was accompanied by a source archive containing submodules (like https://github.com/mumble-voip/mumble/releases/download/1.3.4/mumble-1.3.4.tar.gz) in addition to the archive GitHub produces for the associated tag.
@TerryGeng commented on GitHub (Jan 17, 2022):
I believe this issue can be considered as part of https://github.com/mumble-voip/mumble/issues/5434.
@Krzmbrzl commented on GitHub (Jan 17, 2022):
Yes, indeed. @davidebeatrici is already in the process of preparing the sources.
In the meantime the easiest way would be for you to just use git to clone the repo and check out the respective tag (and init the submodules).
Closing this as a duplicate of #5434