mirror of
https://github.com/mumble-voip/mumble.git
synced 2026-03-03 00:46:56 -05:00
FR: Unclack/Knatter #2671
Labels
No labels
GlobalShortcuts
Hacktoberfest
accessibility
acl
asio
audio
bonjour
bsd
bug
build
certificate
ci
client
code
documentation
external-bug
feature-request
gRPC
github
good first issue
help wanted
help-needed
ice
installer
linux
macOS
needs-ckeck-with-latest-version
needs-more-input
overlay
positional audio
priority/P0 - Blocker
priority/P1 - Critical
priority/P2 - Important
priority/P3 - Somewhat important
priority/P4 - Low
public-server-registration
qt
recording
release-management
server
stale-no-response
stale-support
support
task
test
theme
translation
triage
ui
windows
wontfix
x64
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mumble-mumble-voip#2671
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AtmanActive on GitHub (Mar 16, 2023).
Context
Voice communication while gaming.
Description
There is a genious way to filter-out keyboard and/or mouse clicking sounds from audio.
It is something we would call type-to-mute, or short-bursted-mutes-on-click, or similar, but since programs that do this already exist, then, for now, I will refer to it as Unclack / Knatter .
Generally speaking, it is a Push-to-Mute special mode, bound to all keypresses (optionally all mouse buttons as well) with the following distinction:
As I was testing Knatter on windows, I was blown away how good this approach works, and wanted to suggest the same functionality to be built in to Mumble, as an optional feature, of course.
There are so many situations where Mumble's Voice-Activated mode works great, but it gets disturbed by loud keyboard and mouse-clicking noises. Unclack/Knatter is a perfect remedy for those situations.
Of course, this feature, if ever built in, should work in conjuction with Voice-Activated and Continuous modes, while it doesn't really make sense with Push-To-Talk mode.
Thanks.
Mumble component
Client
OS-specific?
No
Additional information
No response
@Hartmnt commented on GitHub (Mar 16, 2023):
Sounds like a duplicate of #1864 Any thoughts @Krzmbrzl ?
@Krzmbrzl commented on GitHub (Mar 17, 2023):
Yeah, this is indeed a duplicate of #1864 and as I have written there, attempting to bind to any key that may potentially make a sound when activated, seems futile and also not desirable.
Especially since shortcut APIs seem to tend to go towards not allowing global input monitoring but rather require specific shortcuts to be registered with e.g. the desktop environment (that's what Wayland requires).
Imo something like this should be implemented by a separate tool that interfaces directly with the OS. Doing it inside an application (that must work on different OS with different desktop environments and display managers) just seems too much overhead.
@AtmanActive commented on GitHub (Mar 17, 2023):
How about adding this special Push-To-Mute mode (keydown only with configurable release time) to Shortcuts so we can manually configure which keys to unclack?