mirror of
https://github.com/mumble-voip/mumble.git
synced 2026-03-03 00:46:56 -05:00
Add separate notification setting for image messages #3060
Labels
No labels
GlobalShortcuts
Hacktoberfest
accessibility
acl
asio
audio
bonjour
bsd
bug
build
certificate
ci
client
code
documentation
external-bug
feature-request
gRPC
github
good first issue
help wanted
help-needed
ice
installer
linux
macOS
needs-ckeck-with-latest-version
needs-more-input
overlay
positional audio
priority/P0 - Blocker
priority/P1 - Critical
priority/P2 - Important
priority/P3 - Somewhat important
priority/P4 - Low
public-server-registration
qt
recording
release-management
server
stale-no-response
stale-support
support
task
test
theme
translation
triage
ui
windows
wontfix
x64
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mumble-mumble-voip#3060
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @GeneralUser01 on GitHub (Oct 25, 2025).
Context
No response
Description
In the settings for messages, notifications can be turned on or off for various types of messages but one type that is missing is the image message. This is especially noticible when posting several images at once where others would typically receive one notification per image to dismiss one by one. As for noticing a new image message, I would usually post a description first and that way only one notification is sent regardless of how many complementary images are sent, given that the setting for notifications on text messages is on while that for image messages is off.
To implement this I think image messages could use their own message type and the settings should then have this type added to the list. Note that this would be two types since there is not only "Text message" but also "Private text message" to make the image message equivalents for.
Mumble component
Client
OS-specific?
No
Additional information
No response
@Krzmbrzl commented on GitHub (Dec 23, 2025):
@shubhamkoti cool - for this particular issue, you will want to have a closer look at the
Logclass as well as fieldsqmMessagesand?qmMessageSoundsinSettingsto see how existing event types are handled.Let me know if you have questions
@28arnab commented on GitHub (Jan 16, 2026):
Found this class
Added ImageMessage at the end of enum MsgType. Am i going in the right direction ?
@Hartmnt commented on GitHub (Jan 16, 2026):
@28arnab
Good first step. Now you need to find out where
TextMessageis used and then change the code to use your new enum constant in case the message is an image. How exactly that is determined is the integral part of your solution.@28arnab commented on GitHub (Jan 16, 2026):
The person who raised the issue mentioned about private text message. So we need a private image message along with image message ?
@Krzmbrzl commented on GitHub (Jan 16, 2026):
Yes
@28arnab commented on GitHub (Jan 19, 2026):
This works for ImageMessage ? found msgTextMessage in the file Messages.cpp. Based on that i thought this should work.
@Krzmbrzl commented on GitHub (Jan 19, 2026):
Just try it out and see whether it works or not :)
@28arnab commented on GitHub (Jan 30, 2026):
Help building the project plz
Things i did
@28arnab commented on GitHub (Feb 1, 2026):
@Krzmbrzl to fix Ice component not found: Ice what should i do ?
i found a ice wrapper generater script
@Krzmbrzl commented on GitHub (Feb 1, 2026):
@28arnab you need to use the triplet
x64-windows-static-md. See the build instructions at https://github.com/mumble-voip/mumble/blob/master/docs/dev/build-instructions/build_static.mdAlso, if you used our vcpkg fork with the build script, you'll have to create a Release build (the script doesn't build Debug versions of dependencies)
@28arnab commented on GitHub (Feb 1, 2026):
@Krzmbrzl
1> [CMake] -- Build files have been written to: D:/repositories/community/mumble/build/x64-windows-static-md
1> Extracted CMake variables.
1> Extracted source files and headers.
1> Extracted code model.
1> Extracted toolchain configurations.
1> Extracted includes paths.
1> CMake generation finished.
finally.. had to disable ice now i can generate the make files but then when i try to build
cmake --build .\build\x64-windows-static-md\
[116/569] Building C object src\mumble\rnnoise\CMakeFiles\rnnoise.dir__\rnnoise-src\src\celt_lpc.c.obj
cl : Command line warning D9025 : overriding '/W4' with '/w'
[143/569] Linking C shared library speexdsp.dll
FAILED: speexdsp.dll src/mumble/speexdsp/speexdsp.lib
@Krzmbrzl commented on GitHub (Feb 1, 2026):
then you're still doing something differently from the build instructions. Ice compiles and works on Windows as well.
From what you have written, it is impossible to guess what might be the issue. There is not enough information…
For further help with getting Mumble to build properly, please switch to Matrix (at https://matrix.to/#/#mumble-dev:matrix.org) so we don't derail this issue further with debugging your build setup).
@28arnab commented on GitHub (Feb 11, 2026):
My program compiles after changes but crashes when i try to execute mumble.exe. what should i do ? how to debug this ?