mirror of
https://github.com/photoprism/photoprism.git
synced 2026-03-02 22:57:18 -05:00
Places: Fallback to nearby state if unknown at the precise location #1230
Labels
No labels
ai
android
api
auth
awesome
bug
bug
ci
cli
config
database
declined
deprecated
docker
docs 📚
documents
duplicate
easy
enhancement
enhancement
enhancement
epic
faces
feedback wanted
frontend
hacktoberfest
help wanted
idea
in-progress
incomplete
index
invalid
ios
labels
live
live
low-priority
macos
member-feature
metadata
mobile
nas
needs-analysis
no-coding-required
no-coding-required
observability
performance
places
please-test
plus-feature
priority
pro-feature
question
raspberry-pi
raw
released
released
released
research
resolved
security
sharing
tested
tests
third-party-issue
thumbnails
upgrade
upstream-issue
ux
vector
video
waiting
won't fix
won't fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/photoprism#1230
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Fylax on GitHub (Nov 28, 2021).
What does not work as expected?
New states categorization seems to fail with some coordinates
How can we reproduce it?
Steps to reproduce the behavior:
What behavior do you expect?
Both pictures should be in the "Toscana" state
What version you are using?
211127-86c43159-Linux-x86_64
Any other helpful information?
photoprism places update@lastzero commented on GitHub (Nov 28, 2021):
Looked it up. If I read this correctly, it is 1 m away from the "official" state boundary? 👇
We run a private Nominatim instance that doesn't return the state, other than the official API:
Also note we use S2 Cell IDs which intentionally are less precise to preserve your privacy:
In conclusion, this likely happens in such an edge case because the Mediterranean Sea doesn't belong to the state in the backend database - the image is basically taken on the water.
Wouldn't see it as a high priority bug therefore. I'll change the issue into a "todo", so we can change the API to be less strict at a later time (when multi user support is done).
Let us know when you have other examples that are certainly not an edge case and must be fixed with a higher priority.
@Fylax commented on GitHub (Nov 29, 2021):
Nice edge case, thank you for the explanation.
Definitely not a high-priority task and I can definitely mock the position to be a few meters away.
Just for your reference, as of today, no country seems to claim less than 3 nautical miles (5.6 km) as territorial sea, so for future development, you might use that value for "closest country".
Territorial seas claims by country