mirror of
https://github.com/photoprism/photoprism.git
synced 2026-03-02 22:57:18 -05:00
Docs: Write detailed upgrade guides for each release #1436
Labels
No labels
ai
android
api
auth
awesome
bug
bug
ci
cli
config
database
declined
deprecated
docker
docs 📚
documents
duplicate
easy
enhancement
enhancement
enhancement
epic
faces
feedback wanted
frontend
hacktoberfest
help wanted
idea
in-progress
incomplete
index
invalid
ios
labels
live
live
low-priority
macos
member-feature
metadata
mobile
nas
needs-analysis
no-coding-required
no-coding-required
observability
performance
places
please-test
plus-feature
priority
pro-feature
question
raspberry-pi
raw
released
released
released
research
resolved
security
sharing
tested
tests
third-party-issue
thumbnails
upgrade
upstream-issue
ux
vector
video
waiting
won't fix
won't fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/photoprism#1436
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexislefebvre on GitHub (May 19, 2022).
Is your feature request related to a problem? Please describe.
A config was changed but not explained.
Example:
PHOTOPRISM_DARKTABLE_PRESETSwas renamed toPHOTOPRISM_RAW_PRESETS:github.com/photoprism/photoprism@05d39e8c3cUsers who deployed the project before this release have a
PHOTOPRISM_DARKTABLE_PRESETSconfig in theirdocker-compose.ymlfiles, this value is now obsolete. It can confuse users, for example see https://github.com/photoprism/photoprism/discussions/2206Other example: MariaDB was upgraded to 10.7:
github.com/photoprism/photoprism@36d84de0c4 (diff-e45e45baed)It is not explained on the pages of releases: https://github.com/photoprism/photoprism/releases or https://docs.photoprism.app/release-notes/
In the long term, if users don't update their config, the config in this repo and the config used by the users will diverge, which may end up in unexpected behaviours.
Describe the solution you'd like
Add instructions to upgrade with the changelog on each release. Or add an upgrade guide in a Markdown file or the documentation.
Examples:
Describe alternatives you've considered
.
Additional context
.
@lastzero commented on GitHub (May 19, 2022):
Config Options, Supported Formats and Features
As for general documentation of parameters and features, we have added a knowledge base to our website and added commands that will automatically provide you with this information as part of our latest release:
That's more than most open source projects and proprietary software vendors offer, and you can create a diff to keep up with every detail that changes. Our Community Edition will continue to be a rolling release without SemVer and enterprise grade migration guides.
We may change this later and provide more detail if requested, but right now we can't afford to do that if we are to release all the features the community wants with the current budget. Contributors are welcome to take on the work of writing such upgrade guides.
MariaDB
MariaDB is simply the latest stable version with the improvements you can find in the MariaDB Release Notes. We have added an environment variable that automatically updates the MariaDB schema version, so no manual intervention is required.
I see little purpose in writing a text explaining why it makes sense to use this or any other version: It is the version we are currently using for development and with which the release is tested by us. If for some reason users want to keep an old version, they are free to do so at their own risk.
@alexislefebvre commented on GitHub (May 19, 2022):
Thanks for your answer.
A diff is too huge to read, the last one contains 589 commits 1003 files changed: https://github.com/photoprism/photoprism/compare/220302-0059f429...220517-b9c68f8f
The next time that I upgrade Photoprism, I'll check the changes on the release page and compare my
docker-compose.ymlwith the current one. It should be enough to keep my instance up-to-date.If my issue was unclear, Symfony provides a good example of a good changelog, it explains what has been removed, with replacements when they are available.
@lastzero commented on GitHub (May 19, 2022):
Seems you got this wrong, I meant a diff of the newly added "photoprism show" commands which now always show the currently supported options, features and formats. Not a full git diff! 😜
The raw variable should have better communicated and updated in the examples, no doubt about it. But it's not like we constantly change options and break stuff. The only reason this happend is because we have too much work and I simply forgot, probably assuming this was already done or I discussed it personally with only a few people in the chat. Could have happened with any type of release and upgrade notes.
Be aware Symfony has much greater resources, so you can't just ask us to do the same. We completely agree it would be great to have even better docs, thus we have marked this issue as "help wanted".
By the way, your feedback is greatly appreciated by us! I'm traveling today and have to answer most questions on my mobile phone, so can't edit my answers back and forth to always hit the right tone and go into all details.
@lastzero commented on GitHub (May 20, 2022):
While this can't completely replace handwritten docs, the new "show" commands provide an easy way to see the available options, including a description, in a variety of formats that can be easily compared:
This is work in progress. A future version might even be able to generate upgrade docs with detailed comparisons, so you don't even have to run
diffmanually.@Morl99 commented on GitHub (Jul 16, 2022):
Instead of relying on manually written docs, it could be very helpful to print warnings for all Environment variables that match PHTOPRISM_ but that are not recognized by the current version of photoprism. This will make it really easy to catch configuration bugs, no matter if they originate from a version upgrade or from a simple typo.