mirror of
https://github.com/photoprism/photoprism.git
synced 2026-03-02 22:57:18 -05:00
Auth: Add authorize API endpoint to implement the authorization code flow #2132
Labels
No labels
ai
android
api
auth
awesome
bug
bug
ci
cli
config
database
declined
deprecated
docker
docs 📚
documents
duplicate
easy
enhancement
enhancement
enhancement
epic
faces
feedback wanted
frontend
hacktoberfest
help wanted
idea
in-progress
incomplete
index
invalid
ios
labels
live
live
low-priority
macos
member-feature
metadata
mobile
nas
needs-analysis
no-coding-required
no-coding-required
observability
performance
places
please-test
plus-feature
priority
pro-feature
question
raspberry-pi
raw
released
released
released
research
resolved
security
sharing
tested
tests
third-party-issue
thumbnails
upgrade
upstream-issue
ux
vector
video
waiting
won't fix
won't fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/photoprism#2132
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lastzero on GitHub (Jul 3, 2024).
As a user, I want to be able to connect mobile/native apps to my PhotoPrism instance(s) without having to manually generate app passwords through the web interface and then enter them in the app's settings.
For this, the
GET /api/v1/oauth/authorizeAPI endpoint should gather consent and authorization from resource owners when using the Authorization Code Grant flow, optionally with PKCE:Since we are using the (OpenID Foundation certified)
github.com/zitadel/oidclibrary for the recently released OIDC client implementation, theauthorizeanduserinfoAPI endpoints should also be based on it (as much as possible):In addition, all pull requests should include unit tests - at least for the core functionality - to ensure that the changes work as expected: https://docs.photoprism.app/developer-guide/pull-requests/#acceptance-criteria
Documentation:
Protocol References:
Related Issues:
@andiz2 commented on GitHub (Jul 13, 2024):
Hi friends! I can take care of this endpoint :).
Would be so much fun.
@lastzero commented on GitHub (Jul 13, 2024):
@andiz2 Excellent! Since we are using the (OpenID Foundation certified)
github.com/zitadel/oidclibrary for the recently released OIDC client implementation, theauthorizeanduserinfoAPI endpoints should also be based on it (as much as possible). I suggest starting withGET /api/v1/oauth/userinfoas this should be easier.Do you already have experience developing in Go? I'll be happy to help and give feedback on possible solutions before you implement them :)
@andiz2 commented on GitHub (Jul 13, 2024):
@lastzero Thanks for infos :). I've developed some projects in Go before so I can say I have some experience but I appreciate your kindness and will contact you for clarifications and feedback for sure.