mirror of
https://github.com/photoprism/photoprism.git
synced 2026-03-02 22:57:18 -05:00
HEIC: Compatibility with iOS 18 image files #2161
Labels
No labels
ai
android
api
auth
awesome
bug
bug
ci
cli
config
database
declined
deprecated
docker
docs 📚
documents
duplicate
easy
enhancement
enhancement
enhancement
epic
faces
feedback wanted
frontend
hacktoberfest
help wanted
idea
in-progress
incomplete
index
invalid
ios
labels
live
live
low-priority
macos
member-feature
metadata
mobile
nas
needs-analysis
no-coding-required
no-coding-required
observability
performance
places
please-test
plus-feature
priority
pro-feature
question
raspberry-pi
raw
released
released
released
research
resolved
security
sharing
tested
tests
third-party-issue
thumbnails
upgrade
upstream-issue
ux
vector
video
waiting
won't fix
won't fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/photoprism#2161
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @graciousgrey on GitHub (Aug 2, 2024).
Originally assigned to: @lastzero on GitHub.
As an iPhone user, I want PhotoPrism to also support HEIC images taken with the latest iOS 18 beta so I can properly index and view them.
This particular issues seems be fixed with the latest version of
libheif:However, we need to test the latest version first, as the previous version caused image rotation issues with older iOS versions, which apparently did not set the orientation correctly (i.e. they rotated the image with video attributes and changed the orientation with Exif at the same time), causing these images to be displayed incorrectly with newer libheif versions.
Related Issues:
Some of these issues have image files attached that caused orientation issues and can therefore be used to test the latest version of the
heif-convertcommand that comes withlibheif. In addition, our sample archive contains may HEIC files you can use for testing.Alternative Solutions:
libvipsinstead of using theheif-converttool to generate JPEGs from HEIC files first. However, this also requires intensive testing for compatibility with all iOS versions and will not work with Linux kernel < 3.17 and on 32-bit devices aslibvipsis not compatible.Any help in testing the latest versions of
libheifand/orlibvipswould be much appreciated!For this purpose, our sample archive contains HEIC image files created with different iPhone and iOS versions:
We also provide
libheifbinary installation packages in different versions that include theheif-converttool:We are happy to answer your questions either here or by email if you need help with testing. Please note, however, that our team will be on vacation until August 19 and may not be able to respond during this time.
@lastzero commented on GitHub (Aug 2, 2024):
I tested the latest libheif v1.18.1 and found that the generated JPEG images are now oriented incorrectly (images taken with iOS 18.0 seem to work, but have the same issue from what I can see):
In addition, the conversion command included in
libheifv1.18.1 is calledheif-dec, as opposed toheif-convertinlibheifv1.17.1, which is likely to cause another series of problems for users who are not using our Docker images, but locally installed dependencies instead.The original image along with a correctly oriented JPEG version generated with libheif v1.17.1 can be found on our public demo at https://demo.photoprism.app/library/private?view=cards&order=newest&q=meerkats:
You can also find it on your public download server:
Since our team is on vacation until August 19, it would be super amazing if someone from our community could take another look at it to find out what the exact problem is, e.g. by contacting Apple and/or the libheif maintainer to get more information. Feel free to use our sample images for this! 🖼️
@lastzero commented on GitHub (Aug 3, 2024):
Good news, everyone! 🎉
(a) The image orientation seems to be fixed with these changes, which simply set the Exif
Orientationtag value to 1 after new JPEG files have been generated withheif-dec(libheifexecutable, which converts HEIC files to JPEG).(b) Since older versions of the same command (previously named
heif-convert) behave differently according to our tests, we also added the new config optionPHOTOPRISM_HEIFCONVERT_ORIENTATIONwhich allows you to change the behavior, e.g. in case you do not use our official Docker images or this changes again in a future release:COMMANDORIENTATIONof images generated with libheif (reset, keep)@lastzero commented on GitHub (Aug 3, 2024):
Based on my tests, there is still one HEIC image with a wrong JPEG orientation:
However, since it's from an iPhone 7 and the camera software is displayed as "ProCam 10.5.8", I believe it's not a problem with
libheif, but with the file itself.An updated preview build is now available on Docker Hub, so you can test
libheifv1.18.1 together with our latest changes and improvements:@graciousgrey commented on GitHub (Aug 20, 2024):
Looks good to me 👍
@mat1990dj commented on GitHub (Aug 26, 2024):
Hi all, after spending a couple of hours trying to figure out why my iPhone's 15PM pictures were not displayed in photoprism, by my wife's exact same phone, were displaying correctly I thought about it being iOS 18 (I have the beta) and bingo, here's the right issue.
Pictures are uploaded via webdav with photosync and moved to originals by photoprism but jpegs are not created even though the log says:
photoprism-photoprism-1 | time="2024-08-26T17:45:16Z" level=info msg="convert: converting 20240825_183512_401ADC2B.heic to 20240825_183512_401ADC2B.heic.jpg (heif-convert)"I've read the thread but unsure how to help and continue, I've got MANY example pictures to use.
Is there a build that fixes this?
@lastzero commented on GitHub (Aug 26, 2024):
As mentioned above, an updated preview build is available for you to test this:
https://docs.photoprism.app/getting-started/updates/#development-preview
@mat1990dj commented on GitHub (Aug 26, 2024):
Aaaghhh totally missed that, sometimes github compresses the thread and hides replies.
Shall I reindex the folder I know that contains the heif images (since I joined beta basically) ?
Edit: It's generating sidecars!
@Jmoati commented on GitHub (Sep 10, 2024):
Work fine after a new
convertandindex.Thank you.