OIDC: Update dependencies of the "dummy-oidc" service and add tests #2454

Open
opened 2026-02-20 01:11:46 -05:00 by deekerman · 1 comment
Owner

Originally created by @lastzero on GitHub (Dec 10, 2025).

Originally assigned to: @graciousgrey on GitHub.

Required fixes and improvements for the dummy-oidc service that we use in our development environment:

  • Bump dummy OIDC to github.com/zitadel/oidc v1.13.5, update imports, and refresh go.mod/go.sum.
  • Improve server robustness: graceful shutdown, request timeouts, error handling, and ParseForm 400 handling.
  • Add concise package/function comments and separate ConfClient into mock/client.go.
  • Implement missing interface methods for the updated OIDC API (ResponseMode, RevokeToken) and improve rand error handling.
  • Add unit tests for login handler, response mode defaults, and RevokeToken; ensure all tests pass.
  • Lint must be clean (golangci-lint run ./...).
Originally created by @lastzero on GitHub (Dec 10, 2025). Originally assigned to: @graciousgrey on GitHub. Required **fixes and improvements** for the `dummy-oidc` service that we use in our **development** environment: - Bump dummy OIDC to `github.com/zitadel/oidc v1.13.5`, update imports, and refresh `go.mod`/`go.sum`. - Improve server robustness: graceful shutdown, request timeouts, error handling, and ParseForm 400 handling. - Add concise package/function comments and separate `ConfClient` into `mock/client.go`. - Implement missing interface methods for the updated OIDC API (`ResponseMode`, `RevokeToken`) and improve rand error handling. - Add unit tests for login handler, response mode defaults, and `RevokeToken`; ensure all tests pass. - Lint must be clean (`golangci-lint run ./...`).
Author
Owner

@lastzero commented on GitHub (Dec 11, 2025):

@graciousgrey All existing tests seem to pass with the new image, so this should be OK. If you agree, you can close this and move it to released.

@lastzero commented on GitHub (Dec 11, 2025): @graciousgrey All existing tests seem to pass with the new image, so this should be OK. If you agree, you can close this and move it to released.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/photoprism#2454
No description provided.