Stacks: Stack -edited files from Google Photos with original #837

Open
opened 2026-02-19 23:59:50 -05:00 by deekerman · 3 comments
Owner

Originally created by @graciousgrey on GitHub (Mar 8, 2021).

Originally assigned to: @lastzero on GitHub.

As user, I want PhotoPrism to stack files with filenames like "IMG-123.jpg" and "IMG-123-edited.jpg, so that files I have edited using Google Photos are stacked.

As described in https://github.com/photoprism/photoprism/issues/1118: The -edited files from Google might not have correct exif metadata.

Acceptance Criteria:

  • Add pattern for -edited to sequential name stacking
  • Make sure that the taken at date of the not-edited version is used
  • Use the edited version as primary file
  • Add unit test
Originally created by @graciousgrey on GitHub (Mar 8, 2021). Originally assigned to: @lastzero on GitHub. As user, I want PhotoPrism to stack files with filenames like "IMG-123.jpg" and "IMG-123-edited.jpg, so that files I have edited using Google Photos are stacked. As described in https://github.com/photoprism/photoprism/issues/1118: The -edited files from Google might not have correct exif metadata. **Acceptance Criteria:** * Add pattern for -edited to sequential name stacking * Make sure that the taken at date of the not-edited version is used * Use the edited version as primary file * Add unit test
Author
Owner

@inthreedee commented on GitHub (Dec 1, 2021):

This seems like the most relevant issue in which to note this: Something seems to have changed with the handling of photos marked _edited and stacks of these photos are created inconsistently now. When handling is added for -edited photos, it might be a good time to revisit why _edited photos aren't being reliably stacked.

Background:
In https://github.com/photoprism/photoprism/issues/1028, I noted that I use the Photosync app to upload my photos. It marks edits as _edited and they were being stacked reliably at the time. I've just uploaded a large batch of new travel photos and some edited photos are stacked while others are not. It's very inconsistent and I've been unable to find a reason for it. The photos, names, and metadata are identical except for the _edited name. From what I can tell, manually stacking is not implemented yet so I don't see a way I can fix this.

@inthreedee commented on GitHub (Dec 1, 2021): This seems like the most relevant issue in which to note this: Something seems to have changed with the handling of photos marked `_edited` and stacks of these photos are created inconsistently now. When handling is added for `-edited` photos, it might be a good time to revisit why `_edited` photos aren't being reliably stacked. _Background:_ In https://github.com/photoprism/photoprism/issues/1028, I noted that I use the Photosync app to upload my photos. It marks edits as `_edited` and they were being stacked reliably at the time. I've just uploaded a large batch of new travel photos and some edited photos are stacked while others are not. It's very inconsistent and I've been unable to find a reason for it. The photos, names, and metadata are identical except for the `_edited` name. From what I can tell, manually stacking is not implemented yet so I don't see a way I can fix this.
Author
Owner

@lastzero commented on GitHub (Dec 1, 2021):

From the back of my brain, we only have a special handling for Apple iPhone exported files where the edited version may start with an E, for example E1234.jpg and 1234.jpg.

Don't remember to have implemented any special rules for files having _edited and/or -edited in their name. Note that stacks may also be created when you (re-)index a second or third time as more information is already available at the time of indexing a particular file.

@lastzero commented on GitHub (Dec 1, 2021): From the back of my brain, we only have a special handling for Apple iPhone exported files where the edited version may start with an `E`, for example `E1234.jpg` and `1234.jpg`. Don't remember to have implemented any special rules for files having `_edited` and/or `-edited` in their name. Note that stacks may also be created when you (re-)index a second or third time as more information is already available at the time of indexing a particular file.
Author
Owner

@OEvgeny commented on GitHub (Jan 16, 2022):

Note that when using Google Takeout with a locale different to english to get all photos from Google Photos service, -edited gets replaced with the localized name 😒 . Here is an example folder listing for russian locale:

IMG_20190804_153448.jpg*
IMG_20190804_153448.jpg.json*
IMG_20190804_153448-измененный.jpg*
IMG_20190804_153911.jpg*
IMG_20190804_153911.jpg.json*
IMG_20190804_153911-измененный.jpg*
IMG_20190804_153921.jpg*
IMG_20190804_153921.jpg.json*
IMG_20190804_153921-измененный.jpg*
@OEvgeny commented on GitHub (Jan 16, 2022): Note that when using Google Takeout with a locale different to english to get all photos from Google Photos service, -edited gets replaced with the localized name 😒 . Here is an example folder listing for russian locale: ``` IMG_20190804_153448.jpg* IMG_20190804_153448.jpg.json* IMG_20190804_153448-измененный.jpg* IMG_20190804_153911.jpg* IMG_20190804_153911.jpg.json* IMG_20190804_153911-измененный.jpg* IMG_20190804_153921.jpg* IMG_20190804_153921.jpg.json* IMG_20190804_153921-измененный.jpg* ```
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/photoprism#837
No description provided.