Flaky TestMediaFile_GetColors_Slow test #89

New issue

Closed

opened 2026-02-19 23:02:08 -05:00 by deekerman · 4 comments

deekerman commented

2026-02-19 23:02:08 -05:00

Owner

Originally created by @skunert on GitHub (Apr 20, 2019).

Originally assigned to: @skunert on GitHub.

Sadly, TestMediaFile_GetColors_Slow is now flaky because of PR #103. The output of the prominentcolors library depends on some random parameters in the algorithm.
I think we should move the discussion here instead of the PR.

Originally created by @skunert on GitHub (Apr 20, 2019). Originally assigned to: @skunert on GitHub. Sadly, TestMediaFile_GetColors_Slow is now flaky because of PR #103. The output of the prominentcolors library depends on some random parameters in the algorithm. I think we should move the discussion here instead of the PR.

deekerman

2026-02-19 23:02:08 -05:00

closed this issue
added the
declined
label

deekerman commented

2026-02-19 23:02:09 -05:00

Author

Owner

@skunert commented on GitHub (Apr 20, 2019):

I have ideas how to fix the issue, but do not have time until monday. Will get to it then.

@skunert commented on GitHub (Apr 20, 2019): I have ideas how to fix the issue, but do not have time until monday. Will get to it then.

deekerman commented

2026-02-19 23:02:09 -05:00

Author

Owner

@lastzero commented on GitHub (Apr 25, 2019):

I've just pushed an implementation that doesn't use random numbers. It also enables us to search specific parts of an image (3x3 pixels = up to 9 colors). Seems to work well for now! A friend of mine did that long ago for an art project, not sure if it's an official algorithm 😉

Of course you can have the bounty for #7 if you like, see https://issuehunt.io/r/photoprism/photoprism/issues/7

@lastzero commented on GitHub (Apr 25, 2019): I've just pushed an implementation that doesn't use random numbers. It also enables us to search specific parts of an image (3x3 pixels = up to 9 colors). Seems to work well for now! A friend of mine did that long ago for an art project, not sure if it's an official algorithm 😉 Of course you can have the bounty for #7 if you like, see https://issuehunt.io/r/photoprism/photoprism/issues/7 ![Screenshot 2019-04-26 at 02 30 23](https://user-images.githubusercontent.com/301686/56776208-467b0480-67cb-11e9-9d3f-99e0ec4175ab.png)

deekerman commented

2026-02-19 23:02:09 -05:00

Author

Owner

@skunert commented on GitHub (Apr 26, 2019):

Okay, I was too slow :D. But nice that you fixed it so quickly, sorry for the hassle.

@skunert commented on GitHub (Apr 26, 2019): Okay, I was too slow :D. But nice that you fixed it so quickly, sorry for the hassle.

deekerman commented

2026-02-19 23:02:09 -05:00

Author

Owner

@lastzero commented on GitHub (Apr 26, 2019):