mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
After 4.2.0 the maindata endpoint that WebUI uses has a changed behaviour for completed_on #10785
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#10785
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ajohnsen on GitHub (Aug 6, 2020).
Please provide the following information
qBittorrent version and Operating System
4.2 docker from linuxserver
If on linux, libtorrent-rasterbar and Qt version
What is the problem
After upgrading to 4.2 the completed_on data that is returned for torrents for the maindata endpoint has changed.
Before the upgrade (<4.2):
If the torrent wasn't finished the number/date returned for completed_on was 4294967295, making them appear on top of the list (newest) when sorting by 'completed on' in the WebUI.
After the upgrade (>=4.2):
If the torrent isn't finished the number/date returned for the completed_on is now -3600, which puts this torrent at the bottom on the list (with the oldest finished torrents) when sorting by 'completed on'.
What is the expected behavior
Unfinished torrents shouldn't have completed on dates in the past, because that can never happen.
It should rather be like it was before where it stayed next to the recently finished.
Steps to reproduce
Sort by completed_on with unfinished torrents
Extra info(if any)
I first thought the issue was with the WebUI, but after some digging, I saw that the response from maindata had changed.
I'm not very familiar with c++ code, so I haven't been able to check it all. But I have a suspicion that it might have gotten introduced with this commit:
github.com/qbittorrent/qBittorrent@2346bc8f7cRelated issues that have reported it for the GUI:
https://github.com/qbittorrent/qBittorrent/issues/11923
https://github.com/qbittorrent/qBittorrent/issues/11645 (I created this one when I originally discovered the change)
@FranciscoPombal commented on GitHub (Aug 6, 2020):
Closed the previous 2 issues, we only need one about this.
Here's the only other previous thought on this matter from another user (https://github.com/qbittorrent/qBittorrent/issues/11645#issuecomment-569986704):