mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
v4.0.3.1 doesn't rename file extensions properly #11161
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#11161
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ericgur on GitHub (Oct 31, 2020).
Please provide the following information
qBittorrent version and Operating System
Windows 10 x64 20H2
If on linux, libtorrent-rasterbar and Qt version
--
What is the problem
When download completes, some downloaded files (not all) still have the "!qb" file extension.
The files themselves seem complete. Only their name wasn't renamed (remove ".!qb" from end of file name).
What is the expected behavior
Remove ".!qb" from end of file name once download complete.
Steps to reproduce
Download a torrent with more than 1 file in it. The issue occurs in 10/10 torrents I've downloaded.
Extra info(if any)
Reverting to 4.3.0 solved the issue (100%).
Possible hint - if a file within a torrent completes before the others, It will get renamed.
In a torrent with a few small files that get downloaded first, their file name will be correct.
My qBittorrent installation was an upgrade to 4.3.0 which itself was an upgrade to the previous version.
@glassez commented on GitHub (Nov 6, 2020):
@thalieht, @xavier2k6, can you test and confirm it?
@thalieht commented on GitHub (Nov 6, 2020):
Can't reproduce in 4.3.0 nor 4.3.0.1
@thalieht commented on GitHub (Nov 6, 2020):
Maybe some antivirus or whatever is locking the files and doesn't let qBt rename them.
@xavier2k6 commented on GitHub (Nov 6, 2020):
I currently download with the
.!qbextension enabled & not an issue for me - also on windows 10 x64 20H2 Build:19042.610I only have
windows defender, however myFile pool sizeis not the default of40it is set to8000EDIT: Official qBittorrent 4.3.0.1
@xavier2k6 commented on GitHub (Nov 6, 2020):
@ericgur could you provide a link to an example torrent if possible?
@ericgur commented on GitHub (Nov 6, 2020):
Practically any torrent from showrss does the trick.
Example:
The Mandalorian S02E02 1080p DSNP WEBRip DDP5 1 Atmos x264 PHOENiX.zip
The large file will get the issue. Seems like only the file(s) that get completed when the torrent completes has the issue.
I'm back to v4.0.3 and see zero issues.
I'll try to increase the file pool size to 8000 with v4.0.3.1 and report back.
For AV, I use AVG Free.
@ericgur commented on GitHub (Nov 6, 2020):
Initial results using 4.0.3.1 with higher file pool size (8000) are good.
If the default of 40 is too low, maybe it should increase.
It's a little strange that 4.0.3 and earlier versions (on earlier OS versions) don't have this issue but 4.3.0.1 does.
@xavier2k6 commented on GitHub (Nov 6, 2020):
8000may be a bit drastic for the typical user....if it is to be raised....needs to be more realistic perhaps......Could you try setting it to
100?If you still experience the issue, could you increment it by say
10until you no longer experience the issue.If set at
100& you don't experience the issue, could you decrease it by say10until you experience the issue again.@ericgur commented on GitHub (Nov 7, 2020):
100 also works (so far).
I'll try lower settings in the following days.
@FranciscoPombal commented on GitHub (Nov 7, 2020):
@xavier2k6
You're not isolating the anti-virus variable. @ericgur is using AVG while you are using Windows Defender. It would be interesting for you to test with the file pool set to
40. If there is no problem, we can safely claim this is AVG's fault. Of course, raising the default is likely the best way forward still, since AFAIK there is no virtually no downside to raising it (within reason). Not having problems with some antivruses by default is better than having problems with some antiviruses by default.@xavier2k6 commented on GitHub (Nov 8, 2020):
I'm isolating one variable (which in my opinion is more common) - because I see two main use cases/anti-virus variables:
Hence why I believe raising
file pool sizewould be of benefit in this situation.Wouldn't experience this issue.
I will change my
file pool sizeback to default40for testing purposes.....One thing to note though, If the default
file pool sizeis to be raised what needs to be taken in to account as well is thatAVGmay be ok with say50butMcAfeemay need60& let's sayBitDefenderneeds80.file pool sizeon the closing of qBittorrent?@glassez commented on GitHub (Nov 8, 2020):
Guys, can you explain to me how
file pool sizeand antivirus software play here? IIRC, antivirus can lock some files after downloading. But howfile pool sizeaffects it?Sorry I have no time to dig into it myself.
@xavier2k6 commented on GitHub (Nov 8, 2020):
@glassez
ref: https://www.libtorrent.org/reference-Settings.html#file_pool_size
@ericgur commented on GitHub (Nov 8, 2020):
I have tried various file pool size settings, including going to 40 and the issue is gone.
Since the issue happened on ~10 different torrents, spanning several days this looked a simple issue.
This may be related to how the default value is consumed by the app.
Since I can't reproduce anymore, I'm closing the ticket.
Thanks for the excellent support!