Space key will change only one, last checkbox, not all selected. #124

Closed
opened 2026-02-21 14:53:16 -05:00 by deekerman · 4 comments
Owner

Originally created by @ghost on GitHub (Oct 3, 2012).

This will happens on "adding torrent to download" view.

Env: Win7
qBittorrent: 3.0.5

Originally created by @ghost on GitHub (Oct 3, 2012). This will happens on "adding torrent to download" view. Env: Win7 qBittorrent: 3.0.5
Author
Owner

@sorokin commented on GitHub (Nov 15, 2014):

This happens not only in "add torrent" dialog, but also in torrent content tab and in scan folders in options.

Also we have a problem that checkboxes belongs to specific column and spacebar doesn't work if wrong column is selected. Some themes don't even show which column is selected.

@sorokin commented on GitHub (Nov 15, 2014): This happens not only in "add torrent" dialog, but also in torrent content tab and in scan folders in options. Also we have a problem that checkboxes belongs to specific column and spacebar doesn't work if wrong column is selected. Some themes don't even show which column is selected.
Author
Owner

@sledgehammer999 commented on GitHub (Nov 16, 2014):

I am sure this has something to do with the "activate" key of list/model/whatever which is configurable in qt.

@sledgehammer999 commented on GitHub (Nov 16, 2014): I am sure this has something to do with the "activate" key of list/model/whatever which is configurable in qt.
Author
Owner

@sorokin commented on GitHub (Nov 16, 2014):

This is a setData() callstack:

setdata-callstack

I've read the source of functions in callstack. QAbstractItemView::edit is already called for specific cell. So I think we should hook in QAbstractItemView::keyPressEvent.

I'm planning to write our own TorrentContentTreeView with overridden keyPressEvent.

Is this solution ok?

@sorokin commented on GitHub (Nov 16, 2014): This is a setData() callstack: ![setdata-callstack](https://cloud.githubusercontent.com/assets/286877/5061399/52a68a98-6da4-11e4-8a86-4fb9fcd58453.png) I've read the source of functions in callstack. QAbstractItemView::edit is already called for specific cell. So I think we should hook in QAbstractItemView::keyPressEvent. I'm planning to write our own TorrentContentTreeView with overridden keyPressEvent. Is this solution ok?
Author
Owner

@sledgehammer999 commented on GitHub (Nov 16, 2014):

I'm planning to write our own TorrentContentTreeView with overridden keyPressEvent

I am not sure. Ping me again in a few days, because I am looking at other things with the pending pull requests.

So I think we should hook in QAbstractItemView::keyPressEvent.

FYI: Somehow we already process keys presses because pressing F2 in the content pops up the rename dialog.

@sledgehammer999 commented on GitHub (Nov 16, 2014): > I'm planning to write our own TorrentContentTreeView with overridden keyPressEvent I am not sure. Ping me again in a few days, because I am looking at other things with the pending pull requests. > So I think we should hook in QAbstractItemView::keyPressEvent. FYI: Somehow we already process keys presses because pressing F2 in the content pops up the rename dialog.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/qBittorrent#124
No description provided.