mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
Deprecated warnings found in CI - macOS logs. #12515
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#12515
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xavier2k6 on GitHub (Oct 25, 2021).
qBittorrent & operating system versions
qBittorrent:
master branchOperating system: macOS
Qt: 5.15.2/6.2.0
libtorrent-rasterbar: 1.2.14/2.0.4
What is the problem?
While looking through the CI - macOS logs in
master, I came across these "deprecated" warnings:github.com/qbittorrent/qBittorrent@559a979536/src/base/utils/fs.cpp (L350-L358)github.com/qbittorrent/qBittorrent@559a979536/src/base/preferences.cpp (L1127)(GUI=OFF)
github.com/qbittorrent/qBittorrent@559a979536/src/app/main.cpp (L283)Steps to reproduce
No response
Additional context
Take a look at the latest CI - macOS run/logs section of
Build qBittorrent (Qt5) / Build qBittorrent (Qt6)https://github.com/qbittorrent/qBittorrent/actions/runs/1378766147
Log(s) & preferences file(s)
No response
@xavier2k6 commented on GitHub (Oct 25, 2021):
I ignored the other warnings as I know they're being deprecated, we're moving over to
Qt6.@xavier2k6 commented on GitHub (Nov 4, 2021):
@Chocobo1
statfs64deprecation was taken care of by PR https://github.com/qbittorrent/qBittorrent/pull/15661, Could you look into theLSCopyDefaultHandlerForURLScheme&daemondeprecation warnings too please.@Chocobo1 commented on GitHub (Nov 5, 2021):
Sorry, I don't have access to a mac and therefore can't test (nor code) this case.
@xavier2k6 commented on GitHub (Nov 9, 2021):
@Kolcha Can you help with the
LSCopyDefaultHandlerForURLScheme&daemondeprecation warnings?@Kolcha commented on GitHub (Nov 10, 2021):
sorry, I'm not macOS developer at all, and don't know how safely replace these deprecated stuff. I'll look into it this weekend, but can't promise anything
@Kolcha commented on GitHub (Nov 19, 2021):
@xavier2k6 , sorry, I can't fix remaining warnings, at least for now. maybe I'll return later. but again, I don't have Apple devices anymore, except MacBook Pro from office.
@xavier2k6 commented on GitHub (Nov 22, 2021):
@sledgehammer999 something to be looked at prior to 4.4.0 release.
@xavier2k6 commented on GitHub (Dec 11, 2021):
There are now more deprecations that need to be handled.
@xavier2k6 commented on GitHub (Jan 3, 2022):
@sledgehammer999 It's probably too late to address these now with v4.4 about to be GA, should I add it to 4.4.1 milestone?
@xavier2k6 commented on GitHub (Mar 17, 2022):
@sledgehammer999 Going to add this to
4.4.2 milestoneto keep track of/reminder.@xavier2k6 commented on GitHub (Apr 11, 2022):
Deprecations as of macos-12 (monterey)
https://github.com/xavier2k6/qBittorrent/actions/workflows/ci_macos.yaml?query=branch%3ACI_macOS-12_test
@xavier2k6 commented on GitHub (Feb 8, 2023):
Our CI - macOS is now currently running under
12.6.3- so deprecations etc. can be seen there now.@sledgehammer999 @thalieht @glassez
This is what's currently displayed on the main website for
macOS& I'd like to suggest two things for consideration.@glassez commented on GitHub (Feb 10, 2023):
I believe we should completely stop publishing macOS builds so as not to annoy users.
@xavier2k6 commented on GitHub (Apr 28, 2023):
I agree
macOS 13
test/betarunner-image is available now for GHA CI so I will be creating a branch on my repo to test building/deprecations etc.Edit:
GHA CI: Test with macOS 13 Runner Imagehttps://github.com/xavier2k6/qBittorrent/actions/runs/5137434599
Deprecations:
@xavier2k6 commented on GitHub (Jun 12, 2023):
@dmitry1100 @vit9696 @briankendall @MaddTheSane Ping! - In reference to https://github.com/qbittorrent/qBittorrent/issues/15630#issuecomment-1422957536
You've previously submitted PR's for
macOS& would appreciate it if any of you could help providing PR's to handle below:Deprecationsas outlined in https://github.com/qbittorrent/qBittorrent/issues/15630#issuecomment-1528003962@vit9696 commented on GitHub (Jun 12, 2023):
Why deprecations are a problem? Builds for macOS work more or less fine for me.
@glassez commented on GitHub (Jun 12, 2023):
Because after a while it will stop working. Marking some features as deprecated is a way to give developers time to switch to using new features before old ones are completely deleted.
@xavier2k6 commented on GitHub (Sep 24, 2023):
Latest run with
macOS 13runner image:https://github.com/xavier2k6/qBittorrent/actions/runs/6289363171
@DouiKo Could you take a look through the logs & see if you can make any progress with the deprecations please.
@DouiKo commented on GitHub (Sep 25, 2023):
@xavier2k6 I will do my best to do what I can. Should I replace these functions as prompted by the warning and then check for any issues?
@xavier2k6 commented on GitHub (Sep 25, 2023):
Please, anything that you can do to help benefit our macOS userbase.
Only 1 team member has access/uses macOS & that's running Catalina (IIRC)....so we are barely able to support it as is.
With Qt 6.5+ now only supporting macOS 11+............etc.
I will have another issue for you to look into/see if you can implement it......at a later stage, will ping you when I create the associated ticket.....can't do it now....time.
@xavier2k6 commented on GitHub (Oct 14, 2023):
@ackerthehacker2 Any help/fixes you could provide with regards to macOS deprecations/open issues would be much appreciated too.
@101Dude commented on GitHub (Sep 17, 2024):
Adding this here in case it's useful.
While building I see these warnings. I understand they are not build errors. macOS 10.15 and macOS 11 are 4 year old OSs.
Originally posted by @101Dude in https://github.com/qbittorrent/qBittorrent/discussions/21353
@xavier2k6 commented on GitHub (Jul 3, 2025):
@Ryu481 Could you look through latest CI logs & handle/migrate away from these deprecations?
@xavier2k6 commented on GitHub (Sep 22, 2025):
looks like there's more upcoming deprecations while using Qt 6.10...