Add Torrent Dialog Mishandles Single File torrents that contain a folder in the torrent #1354

Closed
opened 2026-02-21 15:37:00 -05:00 by deekerman · 17 comments
Owner

Originally created by @Belove0 on GitHub (Apr 19, 2014).

Qbt 3.1.9 / Windows 7
ISSUE

  • For torrents with a Folder AND a single file in them, the folder/file list is not displayed.
    If you use a default save location, it will work correctly, but if you try to select "Other" to change the destination folder, it has you browse for a location for the FILE in the torrent, not the top folder in the torrent, but the top folder in the torrent is not renamed to match that folder selected if that were the desired behavior.

I can find no combination of folder selection and changing of save location or renaming of the top folder here or after adding the torrent (if Other... was used to select a save location) that can match an existing folder name for the file that is different than already in the torrent (for when wanting to re-seed a torrent one already has). I have not verified where files end up for a new download. But the fact that no matter the folder names selected and location selected (e.g. changing the Save Location to the folder above the file as would be expected and renaming the top folder in the torrent to match that on disk) fails to find the file and perform a recheck.

Workaround for adding an existing file to seed:

  • Move the existing file to the default Save Location and rename it's folder to match the top folder specified in the torrent exactly.
  • After adding the torrent, change the Save Location as desired to move the files back.
  • Rename the top folder in the torrent back to desired folder name (as you had it on disk before, for example.)
  • Recheck the torrent.
  • Celebrate! (it works)

Expected Behavior

  • No matter the number of files in the torrent (including 1), particularly if a folder tree is specified in the torrent, show the folder/file structure in the Add Torrent dialog as is done with multi-file torrents.
  • Allow editing of the folder and filenames as is done with multi-file torrents.
  • The Set Location drop down and "Other..." browsing option select the folder where the entire torrent file structure will be located, not the file itself (contrary to what the dialog now indicates but does not do correctly anyway.)

This issue may be addressed by pull request #937 (?)
This issue may relate to #925

Originally created by @Belove0 on GitHub (Apr 19, 2014). Qbt 3.1.9 / Windows 7 **ISSUE** - For torrents with a Folder AND a single file in them, the folder/file list is not displayed. If you use a default save location, it will work correctly, but if you try to select "Other" to change the destination folder, it has you browse for a location for the FILE in the torrent, not the top folder in the torrent, but the top folder in the torrent is not renamed to match that folder selected if that were the desired behavior. _I can find no combination of folder selection and changing of save location or renaming of the top folder here or after adding the torrent (if Other... was used to select a save location) that can match an existing folder name for the file that is different than already in the torrent (for when wanting to re-seed a torrent one already has). I have not verified where files end up for a new download. But the fact that no matter the folder names selected and location selected (e.g. changing the Save Location to the folder above the file as would be expected and renaming the top folder in the torrent to match that on disk) fails to find the file and perform a recheck._ **Workaround for adding an existing file to seed:** - Move the existing file to the default Save Location and rename it's folder to match the top folder specified in the torrent exactly. - After adding the torrent, change the Save Location as desired to move the files back. - Rename the top folder in the torrent back to desired folder name (as you had it on disk before, for example.) - Recheck the torrent. - Celebrate! (it works) **Expected Behavior** - No matter the number of files in the torrent (including 1), particularly if a folder tree is specified in the torrent, show the folder/file structure in the Add Torrent dialog as is done with multi-file torrents. - Allow editing of the folder and filenames as is done with multi-file torrents. - The Set Location drop down and "Other..." browsing option select the folder where the entire torrent file structure will be located, not the file itself (contrary to what the dialog now indicates but does not do correctly anyway.) _This issue **may** be addressed by pull request_ #937 (?) _This issue may relate to_ #925
Author
Owner

@dpankov commented on GitHub (Mar 28, 2016):

I'm experiencing the same issue even with v3.3.3 on Windows.
I've seen some discussions on similar topics but sadly none of them has addressed this exact problem.
Can we expect a real solution any time soon?

@dpankov commented on GitHub (Mar 28, 2016): I'm experiencing the same issue even with v3.3.3 on Windows. I've seen some discussions on similar topics but sadly none of them has addressed this exact problem. Can we expect a real solution any time soon?
Author
Owner

@zywo commented on GitHub (Mar 28, 2016):

Is that what you're looking for?

screenshot from 2016-03-28 20-00-01

@zywo commented on GitHub (Mar 28, 2016): Is that what you're looking for? ![screenshot from 2016-03-28 20-00-01](https://cloud.githubusercontent.com/assets/4026304/14086987/c62e182e-f51f-11e5-9990-a67fda70a6d5.png)
Author
Owner

@dpankov commented on GitHub (Mar 28, 2016):

Yes, I think so.
Right now I see a similar window but without the "Simple" and "Advanced" radio buttons and more importantly without the bottom folder/file list. The other issue is that the "Browse" button offers me to select a location for the file itself (in your example the .pdf) and not the folder from the payload and after this it automatically adds the subfolder for which I don't have any control over the name.

@dpankov commented on GitHub (Mar 28, 2016): Yes, I think so. Right now I see a similar window but without the "Simple" and "Advanced" radio buttons and more importantly without the bottom folder/file list. The other issue is that the "Browse" button offers me to select a location for the file itself (in your example the .pdf) and not the folder from the payload and after this it automatically adds the subfolder for which I don't have any control over the name.
Author
Owner

@zywo commented on GitHub (Mar 28, 2016):

Because you're using v3.3.3, these features are made in the current master branch and pushed yesterday to 3.3.x branch.
According to @sledgehammer999 https://github.com/qbittorrent/qBittorrent/issues/4940#issuecomment-202324121, the v3.3.4 will be released ASAP.

@zywo commented on GitHub (Mar 28, 2016): Because you're using v3.3.3, these features are made in the current master branch and pushed yesterday to 3.3.x branch. According to @sledgehammer999 https://github.com/qbittorrent/qBittorrent/issues/4940#issuecomment-202324121, the v3.3.4 will be released ASAP.
Author
Owner

@dpankov commented on GitHub (Mar 28, 2016):

:)
This is a great news

@dpankov commented on GitHub (Mar 28, 2016): :) This is a great news
Author
Owner

@dpankov commented on GitHub (Mar 29, 2016):

Sadly it turns out that the 3.3.4 version that I've just installed is missing this fix and still offers the old interface which doesn't allow the folder name to be changed.
:-(

@dpankov commented on GitHub (Mar 29, 2016): Sadly it turns out that the 3.3.4 version that I've just installed is missing this fix and still offers the old interface which doesn't allow the folder name to be changed. :-(
Author
Owner

@zywo commented on GitHub (Mar 30, 2016):

Screenshot ?

@zywo commented on GitHub (Mar 30, 2016): Screenshot ?
Author
Owner

@dpankov commented on GitHub (Mar 30, 2016):

right away
single file folder torrent - save
single file folder torrent - payload

@dpankov commented on GitHub (Mar 30, 2016): right away ![single file folder torrent - save](https://cloud.githubusercontent.com/assets/12518902/14156191/c3c68814-f6cd-11e5-869d-88cd86ee687c.png) ![single file folder torrent - payload](https://cloud.githubusercontent.com/assets/12518902/14156197/c7c05a58-f6cd-11e5-83c9-1145981c9d6a.png)
Author
Owner

@zywo commented on GitHub (Mar 30, 2016):

This is not v3.3.4

@zywo commented on GitHub (Mar 30, 2016): This is not v3.3.4
Author
Owner

@dpankov commented on GitHub (Mar 30, 2016):

sure it is - look at the title bar of the second screenshot

@dpankov commented on GitHub (Mar 30, 2016): sure it is - look at the title bar of the second screenshot
Author
Owner

@dpankov commented on GitHub (Mar 30, 2016):

single file folder torrent - about

@dpankov commented on GitHub (Mar 30, 2016): ![single file folder torrent - about](https://cloud.githubusercontent.com/assets/12518902/14156515/701d4912-f6cf-11e5-96b5-37214a22a58c.png)
Author
Owner

@zywo commented on GitHub (Mar 30, 2016):

In side panel, you must have:

CATEGORIES:
All ()
Uncategorized ()

Not:
LABELS:
All ()
Unlabeled ()

@zywo commented on GitHub (Mar 30, 2016): In side panel, you must have: CATEGORIES: All () Uncategorized () Not: LABELS: All () Unlabeled ()
Author
Owner

@dpankov commented on GitHub (Mar 30, 2016):

zywo,
I don't get it. What are you saying? Is it that the version I have is not the official v3.3.4 and I must re-download it or that there is something else wrong with my installation? What do categories/labels have anything to do with our discussion?

@dpankov commented on GitHub (Mar 30, 2016): zywo, I don't get it. What are you saying? Is it that the version I have is not the official v3.3.4 and I must re-download it or that there is something else wrong with my installation? What do categories/labels have anything to do with our discussion?
Author
Owner

@zywo commented on GitHub (Mar 30, 2016):

Sorry, you're right. I just compiled release-3.3.4 and I notice that this PR https://github.com/qbittorrent/qBittorrent/pull/4784 is not included.
I wonder why.

@zywo commented on GitHub (Mar 30, 2016): Sorry, you're right. I just compiled release-3.3.4 and I notice that this PR https://github.com/qbittorrent/qBittorrent/pull/4784 is not included. I wonder why.
Author
Owner

@dpankov commented on GitHub (Mar 30, 2016):

So is it possible that the change for the single folder&file torrents didn't make it into the official 3.3.4 release?

@dpankov commented on GitHub (Mar 30, 2016): So is it possible that the change for the single folder&file torrents didn't make it into the official 3.3.4 release?
Author
Owner

@thalieht commented on GitHub (Jun 5, 2017):

This is fixed right? Mentioned PR has been merged since 3.3.5.

@thalieht commented on GitHub (Jun 5, 2017): This is fixed right? Mentioned PR has been merged since 3.3.5.
Author
Owner

@ngosang commented on GitHub (Sep 16, 2018):

We are closing all issues related to old qBittorrent versions (qBittorrent < 4.1.0).
Please, update to last release and, if the bug/error/crash is still present, open another issue.
Thank you.

@ngosang commented on GitHub (Sep 16, 2018): We are closing all issues related to old qBittorrent versions (qBittorrent < 4.1.0). Please, update to last release and, if the bug/error/crash is still present, open another issue. Thank you.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/qBittorrent#1354
No description provided.