mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
Completed on doesn't update if the file is completed again #14906
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#14906
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xanatos on GitHub (Aug 27, 2023).
qBittorrent & operating system versions
qBittorrent 4.5.4 x64
Windows 11 (10.0.22xxx)
Qt 5.15.10
Libtorrent 1.2.19
What is the problem?
If a torrent is completed, "damaged" in some way, the completed again, the Completed on date isn't updated with the "newer" completion date. So the Completed on date is the date of "first" completion, while I think it should be the date of "last" completion, so that if you sort that column, you can see which torrents were completed in the last few hours/few days.
Steps to reproduce
Complete a torrent
Damage the files (or remove some of them)
Recheck
Complete again the same torrent
Additional context
No response
Log(s) & preferences file(s)
No response
@thalieht commented on GitHub (Aug 27, 2023):
Not sure what you mean by "damaged". I now tested with deselecting a file and letting the torrent finish and re-select it later. "Completed on" was updated. I use the libtorrent 2 build.
@xanatos commented on GitHub (Aug 27, 2023):
Tried with the 4.5.4 lt 2.0, still the same problem..
Steps:
Download from https://webtorrent.io/free-torrents "Big Buck Bunny" (the site says it is free/creative commons) and let qbittorrent download it.
In my case the Completed on (Completato Il, I have the italian version) column was at 23:11.
Pause it, delete the files Big Buck Bunny.en.srt and poster.jpg from the Explorer
Force recheck:
It is at 99.7%. The Completed on (Completato Il) column is still at 23:11 . Ok.
Now wait two or three minutes, make it restart and finish again. It should be quick.
The torrent completed, but the column Completed on (Completato Il) is still at 23:11. If we check the general details:
The Completed on (Completato Il) is 23:11,
@thalieht commented on GitHub (Aug 27, 2023):
Ok i can reproduce but i'm not sure if this is a bug because it isn't "completed again" but rather "repaired" in this case.
Maybe i'm wrong but i think it would be easier for qBt/libtorrent to update the "completed on" field every time the torrent finishes so the current behavior seems intentional.
@glassez commented on GitHub (Aug 27, 2023):
Could you "transfer" this issue to
libtorrent?@DarkVoyage commented on GitHub (Aug 31, 2023):
This is the case, when you should ask users and don't just change normal behavior. No, complete date should not be updated for torrents that were already downloaded before and were unintentionally damaged. If you want to make it updatable - add option for that.