mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
WebUI default background color #16382
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#16382
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anddam on GitHub (Nov 22, 2024).
qBittorrent & operating system versions
qBittorrent: v5.0.2 (I guess, that's what WebUI's About dialog says)
Operating system: Void Linux
Qt: 6.8.0
Libtorrent: 1.2.19.0
Additional deps:
Boost: 1.86.0
OpenSSL: 3.4.0
zlib: 1.3.1.zlib-ng
What is the problem?
The CSS seems to rely on browsers default white background color, thus uses rgb(0,0,0,0) where it means "white".
When embedded in an iframe with a different background (e.g. in Organizr) this results in very poor readability.
The app should set the base background color it relies on, for instance setting
background color: whiteonbodyelementSteps to reproduce
bodyelementbackground-color: black;to the element styleAdditional context
Log(s) & preferences file(s)
There are no logs or preference involved.
@HanabishiRecca commented on GitHub (Nov 22, 2024):
Yeah, that's another consequence of not setting the background color explicitly.
@skomerko, @Piccirello, maybe we just drop in the background color.
Regarding a particular color choice, as mentioned in https://github.com/qbittorrent/qBittorrent/pull/21498#issuecomment-2399929576, we could use one that Chrome picks -
#121212.And maybe light theme background should be explicitly set too, just in case.
@anddam commented on GitHub (Nov 23, 2024):
Yes, notice that unlike PR #21498 my report is not for dark theme, what you see in the screenshot is the default light theme, only within Organizr that has a black background by default.
This is the same page accessed directly, with Chrome using a white background color
@sk0merko commented on GitHub (Nov 25, 2024):
Will https://github.com/qbittorrent/qBittorrent/pull/21914 be enough to fix your issue?
@anddam commented on GitHub (Nov 28, 2024):
Yep,
In my specific case I configured Organizr to add a CSS rule to the iframe so it had a proper background.