mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
Print the OS version in the crash report #2904
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#2904
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ngosang on GitHub (Aug 6, 2015).
Now we are displaying this info in the log but the OS will be really useful:
http://pastebin.com/nk8Pcy9R
In Linux we can do:
@pmzqla commented on GitHub (Aug 6, 2015):
I don't think we need that.
lsb_release -idrcis probably more useful (but it's not guaranteed that it's available), but I think the information printed are enough. The problem is that often we don't have those information because the bug report is not about a crash for which a stackstrace is generated.We could maybe create a
CONTRIBUTING.mdfile (https://github.com/blog/1184-contributing-guidelines).@Chocobo1 commented on GitHub (Aug 7, 2015):
I plan to add a

copy to clipboardbutton to gather required info for bug reports in "About qbittorrent" tab Library.Something like this:
It's output:
I need some ideas about what info should be included.
@Chocobo1 commented on GitHub (Aug 7, 2015):
Oh, about the original issue. I think adding a simple OS string won't hurt, no need for it's full name.
ex:
@ngosang commented on GitHub (Aug 7, 2015):
Detected Python version? SSL version? If you want to include the compiler and the build time but it's not useful.
For Windows and Mac the OS version and the architecture is enough but in Linux it's not. We don't use advanced kernel features so the kernel version doesn't matter. Instead, it is important to know the distribution and the window manager (GNOME, KDE ...) The problem is there is not a perfect way to obtain that info.
lsb_release -idrcmentioned by @pmzqla it's available only in Debian based distributions. I thinkuname -ais available in all UNIX like systems but the info is incomplete:Linux jkuhh 4.1.2-2-ARCH #1 SMP PREEMPT Wed Jul 15 08:51:45 UTC 2015 i686 GNU/Linux
Instead of Arch Linux you will get 4.1.2-2-ARCH (the distribution compilation number) but in some distributions can be just a number.
For the window manager you can read the environment var
echo $XDG_CURRENT_DESKTOPbut it gives few information. https://askubuntu.com/questions/72549/how-to-determine-which-window-manager-is-runningBefore implementing anything find out if Qt has something to obtain that info.
@Chocobo1 commented on GitHub (Aug 7, 2015):
Is there a data field recording this? Or I need to ask
python -Vexplicitly?IMO it's useful to figure out the user is on what specific version and if he is using an official build.
It gives a hint about the user environment (modern or old) and maybe can correlate with DE/distro. It doesn't carry much useful info, I agree.
About distro version, DE version, I guess gathering all available info is the way...
@ngosang commented on GitHub (Aug 7, 2015):
Utils::Misc::pythonVersionComplete(). You can take a look atUtils::Misc::pythonExecutable()andUtils::Misc::pythonVersion()also.If it's a development version in qBittorrent version you will see v3.3.0beta (I think it's enough)
No. You can not deduct anything about DE/distro. Neither if user environment is old or modern because some distributions as Debian uses old kernels for stability reasons.
Before implementing anything find out if Qt has something to obtain that info.
Look at http://doc.qt.io/qt-5/qsysinfo.html but I think this is only for Windows/Mac.
@Chocobo1 commented on GitHub (Aug 7, 2015):
I've read that.
Many useful functions are Qt5 only, which means it's no use to us right now (since official builds are Qt4).
It will cripple this feature (for now).
Some qbt settings should also be included? ideas?
@pmzqla commented on GitHub (Aug 7, 2015):
I think
lsb_releaseis available for any distro. It's maybe not there by default, but it's not a Debian thing. This is maybe better: http://www.freedesktop.org/software/systemd/man/os-release.html and most of the old distro should at lease have a/etc/*-releasefile.@sledgehammer999 commented on GitHub (Aug 7, 2015):
Some thoughts on this:
uname -a, at least on Debian, gives only the distro name, not the version@Chocobo1 commented on GitHub (Aug 7, 2015):
In this case, we can try store OS name (or whatever info if possible) on qbt startup, and just use these strings when crash occurs.
I always wanted to ask, if recent openssl security holes/fixes affects us too? What subset of openssl function do we (indirectly) utilize?
My arch installation has it...
@sledgehammer999 commented on GitHub (Aug 7, 2015):
I am not sure we are affected by it at all. I think libtorrent uses it for encrypted peers, and for https web seeds and trackers.
We use it in the webui (if user has enabled it in the settings), in the rss, in the updater, in the link downloader.
In my -known expert- opinion even if heartbleed was possible against qbt, the attackers wouldn't find any info. qbt doesn't manage sensitive data/passwards anyway.
@pmzqla commented on GitHub (Aug 7, 2015):
Not sure of this. A button is definitely something that comes in handy. For instance, I can't select and copy the text in the about dialog. A button would make things easier and less error-prone. Not to mention that you can just tell users to open the dialog a click a button.
It would be nice to have the possibility to create templates for bug reports, but this (I guess that if you need to sign up to report a bug, the template created through the URL gets lost) is the best that can be done I think, along with the CONTRIBUTING.md file.
@sledgehammer999 commented on GitHub (Aug 15, 2015):
Since I seem to have left his unfinished before leaving for vacation:
I don't have a problem with a button that copies to clipboard basic info. (like the MPC pic)
@ngosang commented on GitHub (Aug 23, 2015):
In my Archlinux distribution is not installed but most distributions are Debian based and it can be useful.
@ngosang commented on GitHub (Apr 15, 2016):
@Chocobo1 I didn't remember but I think you already did that?
@Chocobo1 commented on GitHub (Apr 15, 2016):
Not exactly the way I proposed before, but it's already merged in qbt (when using Qt5).