starred/qBittorrent

Fork 0

mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-03-02 22:57:32 -05:00

3.4.0 alpha: Icons in Options dialog are messed up #4029

New issue

Closed

opened 2026-02-21 17:05:46 -05:00 by deekerman · 22 comments

deekerman commented

2026-02-21 17:05:46 -05:00

Owner

Originally created by @naikel on GitHub (Mar 8, 2016).

I can't find a way to fix it and I played with a lot of the options in the QtCreator. But right now this is how the options dialog looks since some commits ago:

And I can't understand why they are left to right instead of top to bottom. I'm compiling master branch against Qt 5.5.1.

Originally created by @naikel on GitHub (Mar 8, 2016). I can't find a way to fix it and I played with a lot of the options in the QtCreator. But right now this is how the options dialog looks since some commits ago: ![Dialog](http://i.imgur.com/OdjE6fk.png) And I can't understand why they are left to right instead of top to bottom. I'm compiling master branch against Qt 5.5.1.

deekerman closed this issue

2026-02-21 17:05:48 -05:00

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 8, 2016):

FYR: github.com/qBittorrent/qBittorrent@1c25603686

Your desktop environment?

@Chocobo1 commented on GitHub (Mar 8, 2016): FYR: https://github.com/qBittorrent/qBittorrent/commit/1c256036863f906c800b5d639602a290027d6e45 Your desktop environment?

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@naikel commented on GitHub (Mar 8, 2016):

I'm using XFCE4.

@naikel commented on GitHub (Mar 8, 2016): I'm using XFCE4.

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@naikel commented on GitHub (Mar 8, 2016):

Also if I open the Qt Creator without modifying anything and open the options.ui file looks like this:

So I would think this happens in every platform with Qt 5.5.1... I haven't compiled it for Windows but 85% sure it happens on Windows too.

@naikel commented on GitHub (Mar 8, 2016): Also if I open the Qt Creator without modifying anything and open the options.ui file looks like this: ![Dialog](http://i.imgur.com/iEt5kxT.png) So I would think this happens in every platform with Qt 5.5.1... I haven't compiled it for Windows but 85% sure it happens on Windows too.

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 8, 2016):

Cannot reproduce here.
This is how it looks like in archLinux w/ cinnamon:

Can you try any commit before 1c25603?

@sledgehammer999
Aren't you using xfce too, can you take a look?

@Chocobo1 commented on GitHub (Mar 8, 2016): Cannot reproduce here. This is how it looks like in archLinux w/ cinnamon: ![screenshot](https://cloud.githubusercontent.com/assets/9395168/13624518/e15ee6fe-e5e9-11e5-8e2e-f0476b9d6172.png) Can you try any commit before 1c25603? @sledgehammer999 Aren't you using xfce too, can you take a look?

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 8, 2016):

And the relevant options in Qt creator/designer are:
QListView::flow = TopToBottom, QListView::viewMode = IconMode

@Chocobo1 commented on GitHub (Mar 8, 2016): And the relevant options in Qt creator/designer are: `QListView::flow = TopToBottom`, `QListView::viewMode = IconMode`

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@naikel commented on GitHub (Mar 9, 2016):

@Chocobo1 what version of Qt do you have? Because I compiled master in another host using Qt 4.8.6 and this bug doesn't happen. It looks like it is not compatible with Qt 5.5.1

@naikel commented on GitHub (Mar 9, 2016): @Chocobo1 what version of Qt do you have? Because I compiled master in another host using Qt 4.8.6 and this bug doesn't happen. It looks like it is not compatible with Qt 5.5.1

deekerman commented

2026-02-21 17:05:50 -05:00

Author

Owner

@naikel commented on GitHub (Mar 9, 2016):

Tests with Qt 5.5.1:

Compiled master branch at aa246f0 (one commit before 1c25603): Dialog icons look fine.

Compiled master branch at 1c25603 (the commit referenced above): Dialog icons look messed up.

So that's definitely the commit that doesn't work with Qt 5.5.1.

EDIT: By the way I loved your work when I saw it on Qt 4.8.6. It definitely looks nicer. I hope you could reproduce it in Qt 5.5.1

@naikel commented on GitHub (Mar 9, 2016): Tests with Qt 5.5.1: Compiled master branch at aa246f0 (one commit before 1c25603): Dialog icons look fine. Compiled master branch at 1c25603 (the commit referenced above): Dialog icons look messed up. So that's definitely the commit that doesn't work with Qt 5.5.1. EDIT: By the way I loved your work when I saw it on Qt 4.8.6. It definitely looks nicer. I hope you could reproduce it in Qt 5.5.1

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 9, 2016):

@Chocobo1 what version of Qt do you have?

Qt 5.5.1 here.
I actually tested that commit on Windows & arch linux. I incline to say the culprit is at xfce.
Qt 5.6 should be released in this month, lets see if that changes anything.

By the way I loved your work when I saw it on Qt 4.8.6. It definitely looks nicer. I hope you could reproduce it in Qt 5.5.1

Thank you!

@Chocobo1 commented on GitHub (Mar 9, 2016): > @Chocobo1 what version of Qt do you have? Qt 5.5.1 here. I actually tested that commit on Windows & arch linux. I incline to say the culprit is at xfce. Qt 5.6 should be released in this month, lets see if that changes anything. > By the way I loved your work when I saw it on Qt 4.8.6. It definitely looks nicer. I hope you could reproduce it in Qt 5.5.1 Thank you!

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@sledgehammer999 commented on GitHub (Mar 9, 2016):

Nope. I just tested with xfce4 on a VM (debian sid). Latest master works.
@naikel I suppose you're doing clean builds, right? make clean sometimes leaves leftover files. It is best to to delete the build dir yourself.

@sledgehammer999 commented on GitHub (Mar 9, 2016): Nope. I just tested with xfce4 on a VM (debian sid). Latest master works. @naikel I suppose you're doing clean builds, right? `make clean` sometimes leaves leftover files. It is best to to delete the build dir yourself.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@naikel commented on GitHub (Mar 9, 2016):

I'm doing clean builds all the time. I'm also on Debian sid (unstable) with Qt 5.5.1+dfsg-6. This is so weird. I'm gonna upgrade to 5.5.1+dfsg-16 to see if it makes any difference, though it shouldn't.

@naikel commented on GitHub (Mar 9, 2016): I'm doing clean builds all the time. I'm also on Debian sid (unstable) with Qt 5.5.1+dfsg-6. This is so weird. I'm gonna upgrade to 5.5.1+dfsg-16 to see if it makes any difference, though it shouldn't.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@sledgehammer999 commented on GitHub (Mar 9, 2016):

I'm doing clean builds all the time. I'm also on Debian sid (unstable) with Qt 5.5.1+dfsg-6. This is so weird. I'm gonna upgrade to 5.5.1+dfsg-16 to see if it makes any difference, though it shouldn't.

I am waiting for this.
Also try unsetting the "flow" property of the tabSelection widget. Does it work?
What happens if you set it to LeftToRight?

@sledgehammer999 commented on GitHub (Mar 9, 2016): > I'm doing clean builds all the time. I'm also on Debian sid (unstable) with Qt 5.5.1+dfsg-6. This is so weird. I'm gonna upgrade to 5.5.1+dfsg-16 to see if it makes any difference, though it shouldn't. I am waiting for this. Also try unsetting the "flow" property of the `tabSelection` widget. Does it work? What happens if you set it to `LeftToRight`?

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@naikel commented on GitHub (Mar 9, 2016):

No dice with the newest 5.5.1 Qt package of Debian sid for me.

This happens when I change it to LeftToRight:

This happens if I change to ListMode:

And, this happens if I change selectionRectVisible to false but then it doesn't look cool like it does when I compile it with Qt 4.8.6:

naikel@debian ~/git/qBittorrent $ uic --help
Usage: /usr/lib/x86_64-linux-gnu/qt5/bin/uic [options] [uifile]
Qt User Interface Compiler version 5.5.1

Ideas?

@naikel commented on GitHub (Mar 9, 2016): No dice with the newest 5.5.1 Qt package of Debian sid for me. This happens when I change it to `LeftToRight`: ![Image](http://i.imgur.com/N9L7KPm.png) This happens if I change to `ListMode`: ![Image](http://i.imgur.com/aio8ItH.png) And, this happens if I change `selectionRectVisible` to `false` but then it doesn't look cool like it does when I compile it with Qt 4.8.6: ![Image](http://i.imgur.com/DhpQZgi.png) ``` naikel@debian ~/git/qBittorrent $ uic --help Usage: /usr/lib/x86_64-linux-gnu/qt5/bin/uic [options] [uifile] Qt User Interface Compiler version 5.5.1 ``` Ideas?

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@zywo commented on GitHub (Mar 10, 2016):

The issue doesn't happen on ubuntu 15.10, master branch compiled with qt4 4.8.6 and qt5 5.4.2.

But I can reproduce it on ubuntu 16.04 installed in VM, with both qt4 4.8.7 and qt5 5.5.1.
The commit aa246f0 is not affected as said by @naikel

Tested under Unity and Gnome DEs.

@zywo commented on GitHub (Mar 10, 2016): The issue doesn't happen on ubuntu 15.10, master branch compiled with qt4 4.8.6 and qt5 5.4.2. But I can reproduce it on ubuntu 16.04 installed in VM, with both qt4 4.8.7 and qt5 5.5.1. The commit aa246f0 is not affected as said by @naikel Tested under Unity and Gnome DEs.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 10, 2016):

Can anyone try this:
uncheck isWrapping: pic

@Chocobo1 commented on GitHub (Mar 10, 2016): Can anyone try this: uncheck `isWrapping`: [pic](https://cloud.githubusercontent.com/assets/9395168/13671755/bba4eb9c-e70c-11e5-8183-584960afad63.png)

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@zywo commented on GitHub (Mar 10, 2016):

@Chocobo1

EDIT: sorry.

@zywo commented on GitHub (Mar 10, 2016): @Chocobo1 EDIT: sorry.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@naikel commented on GitHub (Mar 10, 2016):

Unchecking isWrapping doesn't work for me.

@naikel commented on GitHub (Mar 10, 2016): Unchecking `isWrapping` doesn't work for me.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@zywo commented on GitHub (Mar 10, 2016):

Yes, it worked for me on qtcreator. But after compilation, I get this behavior:

@zywo commented on GitHub (Mar 10, 2016): Yes, it worked for me on qtcreator. But after compilation, I get this behavior: ![screenshot from 2016-03-10 15-54-52](https://cloud.githubusercontent.com/assets/4026304/13673267/92dfc9ea-e6d8-11e5-802a-88c92893d9e5.png)

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@sledgehammer999 commented on GitHub (Mar 10, 2016):

There's something weird with Qt. You tell it LeftToRight and it makes it vertical, while TopToBottom makes it horizontal. Plus all the other issues you report trying various other options.

In case we don't find the actual issue here, I'll revert the commit for v3.3.4. It will be a nightmare if users come complaining here for this.

@sledgehammer999 commented on GitHub (Mar 10, 2016): There's something weird with Qt. You tell it LeftToRight and it makes it vertical, while TopToBottom makes it horizontal. Plus all the other issues you report trying various other options. In case we don't find the actual issue here, I'll revert the commit for v3.3.4. It will be a nightmare if users come complaining here for this.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 10, 2016):

Looks like I'll have to try ubuntu 16.04 + unity myself.

In case we don't find the actual issue here, I'll revert the commit for v3.3.4. It will be a nightmare if users come complaining here for this.

Are you going to release 3.3.4 ?

@Chocobo1 commented on GitHub (Mar 10, 2016): Looks like I'll have to try ubuntu 16.04 + unity myself. > In case we don't find the actual issue here, I'll revert the commit for v3.3.4. It will be a nightmare if users come complaining here for this. Are you going to release 3.3.4 ?

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@Chocobo1 commented on GitHub (Mar 11, 2016):

@naikel, @zywo
Please try PR #4939.

@Chocobo1 commented on GitHub (Mar 11, 2016): @naikel, @zywo Please try PR #4939.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@zywo commented on GitHub (Mar 11, 2016):

@Chocobo1
Your PR solves the problem. Tested on Ubuntu 16.04 under Unity and Gnome with qt4 4.8.7 and qt5 5.5.1.

@zywo commented on GitHub (Mar 11, 2016): @Chocobo1 Your PR solves the problem. Tested on Ubuntu 16.04 under Unity and Gnome with qt4 4.8.7 and qt5 5.5.1.

deekerman commented

2026-02-21 17:05:51 -05:00

Author

Owner

@naikel commented on GitHub (Mar 11, 2016):

PR #4939 works indeed but looks like it has always looked. That means when an icon is selected, the selection only highlights the text and not the whole rectangle.

But it works.

@naikel commented on GitHub (Mar 11, 2016): PR #4939 works indeed but looks like it has always looked. That means when an icon is selected, the selection only highlights the text and not the whole rectangle. But it works.

deekerman referenced this issue

2026-02-21 17:54:18 -05:00

Steps for version 3.4 release #5525