3.4.0 Sets "Global ratio" when "Share Ratio Limiting" is unchecked. #4057

New issue

Closed

opened 2026-02-21 17:06:39 -05:00 by deekerman · 3 comments

deekerman commented

2026-02-21 17:06:39 -05:00

Owner

Originally created by @chrishirst on GitHub (Mar 16, 2016).

When NOT using the "Add new torrent" dialogue, "Use global ratio limit" is selected for the task even when "share ratio limiting" is unchecked in Options. -> Bittorrent.

The expected behaviour under those conditions should be to have "No ratio limit" set for the loaded task.

Originally created by @chrishirst on GitHub (Mar 16, 2016). When **NOT using** the "Add new torrent" dialogue, "Use global ratio limit" is selected for the task even when "share ratio limiting" is **unchecked** in Options. -> Bittorrent. The expected behaviour under those conditions should be to have "No ratio limit" set for the loaded task.

deekerman closed this issue

2026-02-21 17:06:41 -05:00

deekerman commented

2026-02-21 17:06:43 -05:00

Author

Owner

@sledgehammer999 commented on GitHub (Mar 16, 2016):

I'll take a look for this in v3.3.4 (anyone else is also welcome)

@sledgehammer999 commented on GitHub (Mar 16, 2016): I'll take a look for this in v3.3.4 (anyone else is also welcome)

deekerman commented

2026-02-21 17:06:43 -05:00

Author

Owner

@sledgehammer999 commented on GitHub (Mar 17, 2016):

Now that I am reading this again this behavior is correct. "use global ratio limit" does nothing if you have "share ratio limiting" disabled.
"Use global ratio limit" can be either "no limit" or "a specific limit" depending if what you have enabled in the preferences. Thus it is "global".

The other 2 settings you see when right clicking a task -> limit share ratio are used to override the global setting for that particular task.

@sledgehammer999 commented on GitHub (Mar 17, 2016): Now that I am reading this again this behavior is correct. "use global ratio limit" does nothing if you have "share ratio limiting" disabled. "Use global ratio limit" can be either "no limit" or "a specific limit" depending if what you have enabled in the preferences. Thus it is "global". The other 2 settings you see when right clicking a task -> limit share ratio are used to override the global setting for that particular task.

deekerman commented

2026-02-21 17:06:43 -05:00

Author

Owner

@chrishirst commented on GitHub (Mar 18, 2016):

Now that I am reading this again this behavior is correct. "use global ratio limit" does nothing if you have "share ratio limiting" disabled.

But it doesn't, if I add a task without explicitly setting "Set no ratio limit" from the context menu the task WILL pause as soon as it completes downloading and should start seeding, if i set the global action to "Remove" then disable ratio limiting the task WILL removed instead.

The other 2 settings you see when right clicking a task -> limit share ratio are used to override the global setting for that particular task.

If share ratio limiting is disabled, it should not also be necessary to use the context menu to set no ratio limit. Disabling ratio limiting should be "Set no ratio limit" not be "use the global setting anyway".

@chrishirst commented on GitHub (Mar 18, 2016): > Now that I am reading this again this behavior is correct. "use global ratio limit" does nothing if you have "share ratio limiting" disabled. But it doesn't, if I add a task without **explicitly** setting "Set no ratio limit" from the context menu the task WILL pause as soon as it completes downloading and should start seeding, if i set the global action to "Remove" then disable ratio limiting the task WILL removed instead. > The other 2 settings you see when right clicking a task -> limit share ratio are used to override the global setting for that particular task. If share ratio limiting is disabled, it should **not also** be necessary to use the context menu to set no ratio limit. Disabling ratio limiting should be "Set no ratio limit" not be "use the global setting anyway".

deekerman referenced this issue

2026-02-21 17:43:51 -05:00

Configurable UI appearance and corresponding options page #5214