Improve Add tracker dialog code #4208

New issue

Closed

opened 2026-02-21 17:11:44 -05:00 by deekerman · 1 comment

deekerman commented

2026-02-21 17:11:44 -05:00

Owner

Originally created by @ngosang on GitHub (Apr 22, 2016).

I fixed two important bugs in #5160 so the dialog is fully functional but the code is awful. I have not much time lately but any of you can fix this in 10 minutes. @qbittorrent/qbittorrent-frequent-contributors

We need to check if the URL is empty and show an alert or disable the download button.
Simplify parseUTorrentList() We shouldn't remove trackers already present in the torrent (this is done later in torrent->addTrackers()). We shouldn't clean the tracker list (it's done in newTrackers()). Just show the alert if there is some network problem and fill the textbox with the URL content.
Remember the trackerlist (save in preferences). You can remember the URL also.

URL to test => https://www.torrentz.com/announcelist_223011259

Originally created by @ngosang on GitHub (Apr 22, 2016). I fixed two important bugs in #5160 so the dialog is fully functional but the code is awful. I have not much time lately but any of you can fix this in 10 minutes. @qbittorrent/qbittorrent-frequent-contributors 1) We need to check if the URL is empty and show an alert or disable the download button. 2) Simplify parseUTorrentList() We shouldn't remove trackers already present in the torrent (this is done later in torrent->addTrackers()). We shouldn't clean the tracker list (it's done in newTrackers()). Just show the alert if there is some network problem and fill the textbox with the URL content. 3) Remember the trackerlist (save in preferences). You can remember the URL also. URL to test => https://www.torrentz.com/announcelist_223011259

deekerman

2026-02-21 17:11:44 -05:00

closed this issue
added the
autoCloseOldIssue
label

deekerman commented

2026-02-21 17:11:49 -05:00

Author

Owner

@sledgehammer999 commented on GitHub (Oct 29, 2020):

This issue has been closed and locked for being too old, and thus either most likely resolved in recent versions or no longer applicable.
If you experience the reported problem or similar in the latest version, please open a new issue report with the requested information in the issue template.

A new issue report with relevant updated data gathered from the latest version is preferable to necroing an old report with a comment like "still happens in version x.y.z", even if you think the bug is the same, or suspect of a regression.
Due to the changes made to the qBittorrent code and its dependencies over time, the exact cause of your problem could be totally different than the original one, despite the visible symptoms of the bug being similar.
Thus, providing relevant updated information is crucial to find and fix the root cause of a recurrent problem or regression.

Thank you for your contributions.

@sledgehammer999 commented on GitHub (Oct 29, 2020): This issue has been closed and locked for being too old, and thus either most likely resolved in recent versions or no longer applicable. If you experience the reported problem or similar in the **latest** version, please open a new issue report with the requested information in the issue template. A new issue report with relevant updated data gathered from the latest version is preferable to necroing an old report with a comment like "still happens in version x.y.z", even if you think the bug is the same, or suspect of a regression. Due to the changes made to the qBittorrent code and its dependencies over time, the exact cause of your problem could be totally different than the original one, despite the visible symptoms of the bug being similar. Thus, providing relevant updated information is crucial to find and fix the root cause of a recurrent problem or regression. Thank you for your contributions.