mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
Support libtorrent option allow_multiple_connections_per_ip #4830
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#4830
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @romanrm on GitHub (Oct 31, 2016).
Hello,
As also posted by someone earlier in https://bugs.launchpad.net/qbittorrent/+bug/894545
I would like to propose supporting libtorrent option "allow_multiple_connections_per_ip" in Advanced settings (off by default).
My reason: due to a specific forwarding+load balancing setup, I see all incoming connections to the torrent client as coming from the same set of 2 or 3 IPs. To be able to accept multiple connections per each IP, I need allow_multiple_connections_per_ip enabled. I have recompiled qBittorrent with that, but the peer list is still shows IPs only once. However this actually works fine, as my total upload speed for each torrent is now way higher, and doesn't match than the sum of upload speeds to peers that I see in the list. (So just a cosmetic issue of making the peer list not group by IP).
Secondly, there are now ISPs which place their customers behind a Carrier-Grade NAT (CGN), where many customers will share the same Internet IP, and will be unfairly limited to just one connection per that IP by other users' torrent clients.
This option opens some abuse potential via multiple client impersonation by remote peers, but personally I am not worried as I'm fine with seeding as fast as people can possibly fetch, and normally have my uplink underutilized anyways. And in any case it won't hurt anyone if it's off by default.
@thalieht commented on GitHub (Jun 12, 2017):
Linking to PR this might fit in... if accepted: #3235
@Seeker2 commented on GitHub (Jun 12, 2017):
Even without this option, you can have the same ip connected multiple times, limited to 1 per torrent.
If this option is added, it needs to be with the stipulation that duplicate ips on the same torrent must be different in some other minor way, like different session/peer id (or if something like that can't be used -- different listening port or BitTorrent client) to mitigate the effects of hostile BitTorrent attacks already seen in the wild.
Another PR this might fit in: https://github.com/qbittorrent/qBittorrent/issues/6421 "I plan to create a PR for missing and hardcoded session settings"