mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
Search does not work when PluginVersion class can not parse plugin version string #5778
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#5778
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @WaterSibilantFalling on GitHub (Jul 13, 2017).
Originally assigned to: @zeule on GitHub.
qBittorrent Newly built 3.4.0
Linux 4.9.0-2-686-pae #1 SMP Debian 4.9.18-1 (2017-03-30) i686 GNU/Linu
libtorrent newly built 1.1.4.0
Python 3 and 2 are installed and running
The Search tab has completely disappeared. Regardless of whether I select view > search, nothing.
In the logs there is nothing related to "search"
There is nothing related to 'search' in the top-level build dir (no configure option that I can see)
If I go into qBittorrent.conf and change "EnableSearch=True", and then run qBittorrent, then qBittorrent runs with the View > Search checkbox checked, but no search tab.
Is there some ./configure option that I should set when building?
@WaterSibilantFalling commented on GitHub (Jul 17, 2017):
I've built it three times now, always it ends up with no search screen/dialog, regardless of the conf file or the menu settings.
Anyone?
@zeule commented on GitHub (Jul 17, 2017):
No. I'm afraid you have to debug it.
MainWindow::displaySearchTab()is a good place to start (insrc/gui/mainwindow.cpp).@WaterSibilantFalling commented on GitHub (Jul 28, 2017):
I don't know if this is being read - if not I will close and open a new, more specific, bug.
This is the first time I have interacted with the qBittorrent source code, and this is what I have found out so far. Someone with more knowledge may be able to point out the underlying problem.
Now, none of this makes any sense. It's like only the base class object is being instantiated - or the qtcreator debugger is completely warped.
--(1)--
in the file qBittorrent/src/gui/search/searchwidget.cpp line 75
The m_ui member is not being instantiated in the initializer list.
--(2 a)--
Then, somehow, I don't know how, the setupUI(SearchWidget) function is being successfully called via this non-existent member pointer
m_ui is an instatiation of
Ui::SearchWidget which is a
UI_SearchWidget
m_ui->setupUI( *SearchWidget ) method is a member of UI_SearchWidget
Control (somehow ) passes to the setupUI( ) method
--(2 b)--
in qBittorrent/src/ui_searchwidget.h line 57
The objectName() function presumably works on some baseclass - a static member? somewhere - that I looked for but could not find. Anyway, that the SearchWidget is fine, and seemingly unchanged, after that call.
THEN, at the resize( ) call, the SearchWidget becomes null.
--(3)--
The remainder of void setupUi(QWidget *SearchWidget) method operates on a null SearchWidget object. qBittorrent carries on as if nothing was the problem. No return values are checked, and the SearchWidget is not tested if it exists or, as in this case, does not exist.
---(4)---
Runtime.
At runtime startup, these errors are produced:
I mean, specifically:
Does this make sense to anyone?
@zeule commented on GitHub (Jul 28, 2017):
This might be a problem. Please, share
/home/me/.local/share/data/qBittorrent/nova3/engines/nyaatorrents.py"@WaterSibilantFalling commented on GitHub (Jul 28, 2017):
.../nova3/engines/nyaatorrents.py
@zeule commented on GitHub (Jul 28, 2017):
Thanks. This is not the plugin which creates the error. Could you, please, do the following (and share output):
@WaterSibilantFalling commented on GitHub (Jul 28, 2017):
The string for rutracker has a MS Windows line termination after it, represented by "^M" on my computer.
@WaterSibilantFalling commented on GitHub (Jul 28, 2017):
.... and Ii've removed that '^M' (I actually removed the 'a' as well 1.04a^M to 1.04)
... and it WORKS!. The search dialogue/tab appears in qBittorrent
That was it (for me at least).
I realize that there might be another problem that I have exposed, feel free to ask for info, files etc, but otherwise (for me at least) this bug can be closed.
If you had not asked me to list the VERSION strings I - or, well, you - would have never, ever found this bug in 1000 years. Thank you very much.
@zeule commented on GitHub (Jul 28, 2017):
I guess the problem was in 'a'.