mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
FIX option "Display notifications for added torrents" does not work without "Display notifications" #5993
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#5993
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @allanlaal on GitHub (Aug 28, 2017).
Use case:
Goal:
I want to get an OSD notification for when a new torrent is added when I click magnet links on sites, so I know the link actually got through and is not a spammy ad trick.
Steps:
I open qBittorrent settings -> Advanced:
I see these options are unchecked:
☐ Display notifications
☐ Display notifications for added torrents
I then check "Display notifications for added torrents", since I only want to get notifications for added torrents, not anything else:
☐ Display notifications
☑ Display notifications for added torrents
Since I grew up in the 90s, I hit Apply settings and restart qBittorrent completely for extra settings saving paranoia points
Expected behaviour:
qBittorrent displays OSD notification for every time a magnet link is clicked or torrent added to autoload dir.
Actual behaviour:
qBittorrent does not display any notifications. The torrent is silently added like before
Notes:
the "torrent added" notification is only displayed when both options are checked (somewhat mentioned in https://github.com/qbittorrent/qBittorrent/pull/6196#issuecomment-278484599):
☑ Display notifications
☑ Display notifications for added torrents
versions:
qBittorrent version: 3.3.15
OS: Ubuntu Mate Linux 16.04 LTS
libtorrent: python-libtorrent 1.0.11+git20172007.1c6025e612-1ppa1~xenial1 amd64
Qt: libqtcore4 4:4.8.7+dfsg-5ubuntu2
@thalieht commented on GitHub (Aug 28, 2017):
I can see the confusion and i think
Display notificationsworks as a control for all notifications. IMO the second option should be disabled/unavailable when the first is unchecked, unless it is changed as you suggest.@allanlaal commented on GitHub (Aug 28, 2017):
I think branching
Display notifications for added torrentsoff to work as a separate feature will add valueLogically thinking, users who need an onscreen notification about new torrents means that they add so many torrents, that they don't want to waste the time to check the main qBittorrent window to verify it manually. This also means those users have so many torrents that getting "torrent finished" notifications will be so frequent and distracting that they can't have
Display notificationsin its current form enabled all the time.That means
Display notificationsin its current form andDisplay notifications for added torrentsare mostly mutually exclusive in their use cases.@thalieht commented on GitHub (Aug 28, 2017):
I think PR #3810 does it.
@mrandreastoth commented on GitHub (Mar 15, 2018):
Hard to tell what #3810 is about. Not only that, it's been waiting to be merged for quite some time now. Seems a simpler and more logical solution for now is to simply rename "Display notifications" to "Display notifications for completed torrents" and make "Display notifications for added torrents" ignore the state of that flag. Such a solution would allow more flexibility and choice.
@allanlaal commented on GitHub (Feb 22, 2019):
PR #3810 did fix this - as of v4.2.0 alpha the issue still persists in the form I originally reported
@sledgehammer999 commented on GitHub (Oct 29, 2020):
This issue has been closed and locked for being too old, and thus either most likely resolved in recent versions or no longer applicable.
If you experience the reported problem or similar in the latest version, please open a new issue report with the requested information in the issue template.
A new issue report with relevant updated data gathered from the latest version is preferable to necroing an old report with a comment like "still happens in version x.y.z", even if you think the bug is the same, or suspect of a regression.
Due to the changes made to the qBittorrent code and its dependencies over time, the exact cause of your problem could be totally different than the original one, despite the visible symptoms of the bug being similar.
Thus, providing relevant updated information is crucial to find and fix the root cause of a recurrent problem or regression.
Thank you for your contributions.