mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
Bind delete shortcut to Delete key on macOS #6106
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#6106
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kstlouis on GitHub (Sep 27, 2017).
Don't really care whether you use the default Command-Delete (on Mac) or some other keyboard shortcut, but anything that helps to navigate the UI keyboard-only is always appreciated.
@Chocobo1 commented on GitHub (Oct 7, 2017):
@kstlouis
Even if the menu doesn't show, the Del key is already binded correctly.
@kstlouis commented on GitHub (Oct 7, 2017):
@Chocobo1
Just tried it, doesn't appear to be working.
Running latest version (3.3.16) on MacOS 10.13.1 (beta). Behaviour was also present on 10.13.0, so don't think it's related to the MacOS version.
To clarify: this should work with the "delete" key (which would be called "backspace" on a Windows keyboard), not the "Del" key that would only be found on the numeric-keypad-equipped keyboards correct? Just making sure we're talking about the same key.
@Chocobo1 commented on GitHub (Oct 7, 2017):
It is the Del key in the famous Ctrl+Alt+Del combination on Windows.
@Chocobo1 commented on GitHub (Oct 7, 2017):
according to http://doc.qt.io/qt-5/qkeysequence.html#standard-shortcuts
it should be Del or Meta+D on macOS.
@kstlouis commented on GitHub (Oct 7, 2017):
@Chocobo1 I found the issue.
This works when pressing the “Del” key on any keyboard with this layout: https://store.apple.com/xc/product/MQ052LL/A, which has a dedicated delete key. The issue is that the overwhelming majority of Apple keyboards have this layout: https://store.apple.com/xc/product/MLA22LL/A, which does not have this key.
I borrowed a wired keyboard which has the numeric keypad to test this, and confirmed that pressing the “Del” key does work as expected. So the documentation you linked to is correct, but does not apply to most users.
Would recommend adding an alternate key binding so that pressing Command+Delete (the “backspace” equivalent, not the dedicated “Del” key as described above) also performs the same function. Otherwise, vast majority of Mac users can’t use this shortcut.
Thanks!
@Chocobo1 commented on GitHub (Oct 8, 2017):
What about Meta+D combination, does it work?
from https://support.apple.com/en-us/HT201236 :
Also, how do other program work, do they also use
Command+Deletefor deleting?@kstlouis commented on GitHub (Oct 8, 2017):
I tried Command+D, Option+D and Ctrl+D, none worked. I did not think to try Fn+D; I’ll try that tomorrow when I am home again.
Command+Delete and Delete by itself are both common. The Delete key by itself is used to remove items in most default applications (Mail and Photos, for instance), but Command+Delete is what is used to move items to the Trash in MacOS’ file manager.
I’ve seen instances of both being used in some applications; ie pressing “Delete” by itself would be followed by a prompt before item removal (“Are you sure...?”), and Command+Delete would remove the item without prompt.
@kstlouis commented on GitHub (Oct 10, 2017):
@Chocobo1 Update: looks like Function+Delete does work on my wireless keyboard; but not Function+D (or Control+D, as implied by the "Meta+D" in the qt.io documentation).
@Chocobo1 commented on GitHub (Oct 10, 2017):
@kstlouis
Just to make sure, do you still wish to bind delete function to the delete key (on macOS keyboard)? Or its alright right now?
@kstlouis commented on GitHub (Oct 14, 2017):
@Chocobo1 If it's feasible to bind it to "Delete" I think it makes sense to do so. Will make the keyboard shortcut more discoverable among Mac users. Either way though, making it visible in the Menu Bar (if possible) would be great.
@Chocobo1 commented on GitHub (Oct 14, 2017):
okay, reopening issue.
It's done in #7563.
@recoi1er commented on GitHub (Mar 23, 2020):
Did this get removed at a later version? None of these work: delete, cmd+Delete, fn+Delete, control+Delete, option/alt+delete. I still have to select it from the top bar which is difficult as it's still going see through on a very constant basis (on v4.2.1)
@rw3iss commented on GitHub (Oct 28, 2020):
FYI, on Mac it's:
Fn + Delete
!!! :-)
@recoi1er commented on GitHub (Jan 18, 2021):
Nice thanks!
Very odd choice to use that binding though, should be Command + Delete to be proper with the design scheme of MacOS
@erango commented on GitHub (Apr 9, 2021):
It's not a choice @recoi1er, Fn + Delete is the Mac equivalent of the windows Delete. They just map to the same key. The standard Mac delete operation, Cmd + Delete, actually maps to the windows equivalent of Backspace
@luzpaz commented on GitHub (Apr 7, 2024):
See #20668 (#20187)
@luzpaz commented on GitHub (Apr 7, 2024):
Closing in favor of #20187