mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
QBittorrent 4.2.0 alpha webui messed up #7360
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#7360
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @trippleflux on GitHub (Jun 1, 2018).
qBittorrent version and Operating System
658702dcbb9e6ed7519c892225014950707faf9e/master branch/4.2.0 alpha shared
Windows 10 X64 Enterprise
Visual Studio 2017 15.7.3
If on linux, libtorrent and Qt version
Libtorrent RC1_1 branch
QT 5.11 Shared x64
What is the problem
QBittorrent 4.2.0 alpha webui messed up
What is the expected behavior
QBittorrent able to load the necessary embedded webui files from the .qrc files.
Steps to reproduce
The steps i have took to make it compile is long tedious ways, looks like on QT 5.11 the QRC compiler (qmlcache) has failed to convert the "mootools-1.2-core-yc.js" & "mootools-1.2-more.js" resources into manageable filename inside the qmlcache_loader.cpp.
So i need to rename the mootools-1.2-core-yc.js & mootools-1.2-more.js into mootools-core-yc.js & mootools-more.js, also replaced the filelist inside the webui.qrc .
Compile the qBittorrent shared with above details and requirement.
Extra info(if any)
QBittorrent Compilation log :
@Kolcha commented on GitHub (Jun 3, 2018):
qBittorrent doesn't use Qt QML. so, any QML-related tools is not required during compilation.
I have newly installed Qt 5.11, but I even didn't find such tool (
qmlcache), it doesn't known to me, I know onlyqmlscene, and it presents in Qt distribution.just for your information, Qt resource compiler is tool called
rcc, and this is not "real compiler", it just converts .qrc files to .cpp, which are compiled by c++ compiler (MSVC in your case) later.I successfully compiled qbt from commit you mentioned (
github.com/qbittorrent/qBittorrent@658702dcbb) using Qt 5.11 and MSVC2017, no any issues happened. I don't like CMake (and not so familiar with it to use it on Windows) + this build system is not well supported by qbt developers, so I used QtCreator (bare qmake is enough too) to build it. I assumed you generated Visual Studio files and used them to build qbt and faced mentioned problem. It is known at least to me when qmake generates incorrect (?) VS files, especially in case of MSVC2017. Generated project files almost always worked for me with any previous Visual Studios (including 2015), but I faced problems with them in case of MSVC2017. I assumed, something significant was changed during 2015->2017 upgrade, but Qt developers didn't change something inside qmake, and it generates "broken" projects. at least I don't recommend use Visual Studio to build Qt apps, use just qmake + MSVC compiler, and jom instead of nmake (that is QtCreator does).@trippleflux commented on GitHub (Jun 4, 2018):
@Kolcha
Wow, it's really strange, hmm, i have deleted CMAKE from my kits setup in qtcreator, also have delete qml dependency from my src.pro, no matter what i have tried it ended up with :
In which this bug is confirmed & reported by QT.
Btw what are your conf.pri content, mine are :
Also i have make sure there is cmake\bin path in my windows env variables.
Also does your QT install is the x64 shared one?, i just want to pinpoint the source of this.
Perhaps the one that you are downloading are the vanila QT 5.11.0 while mine are QT 5.11 branch from code.qt.io which is the QT 5.11.1 pre-release.
So i assume you were using Visual Studio 2017 x64 command prompt?, care to share the .bat/.cmd files for me to use as an example?
@trippleflux commented on GitHub (Jun 4, 2018):
Wew, it seems for some reasons qtcreator is adding CONFIG += qtquickcompiler & QT += QML into the projects by it's own, after adding these into my src/src.pro, i am able to compile using qtcreator & qmake :
Now all qbt features working properly & flawlessly. Should i add pull request for this?.
Thanks @Kolcha 👍
@Kolcha commented on GitHub (Jun 4, 2018):
I used official Qt online installer to install Qt (and QtCreator), I prefer do not compile Qt by myself on Windows, I do it only when I really need in it. So, I have shared Qt libraries, also I compiled all other dependencies as shared libraries.
yes, I also used Visual Studio command prompt and have cmake in path. unfortunately, I can't share any bat/cmd files or just commands what I used to build dependencies. I don't have them. each time when I decide to build qbt, I do this from scratch. I build zlib using cmake, libtorrent - using boost.build, boost and openssl - their official methods, and finally qbt - using qmake.
there is my conf.pri:
P.S> I'm not affected by bug you mentioned. I successfully compiled qbt with Qt 5.11 on 2 computers.
@Kolcha commented on GitHub (Jun 4, 2018):
so, I think issue can be closed. this is not qbt problem, some Qt bug presents there (even approved)
@trippleflux commented on GitHub (Jun 4, 2018):
Yes, looks like it's a bug on the qtcreator or qmake. Thanks man!. Will close this one.