mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2026-03-02 22:57:32 -05:00
qbittorrent.log has overly specific and incorrect error message #7540
Labels
No labels
Accessibility
AppImage
Bounty
Build system
CI
Can't reproduce
Code cleanup
Confirmed bug
Confirmed bug
Core
Crash
Data loss
Discussion
Docker
Documentation
Duplicate
Feature
Feature request
Feature request
Feature request
Filters
Flatpak
GUI
Has workaround
I2P
Invalid
Libtorrent
Look and feel
Meta
NSIS
Network
Not an issue
OS: *BSD
OS: Linux
OS: Windows
OS: macOS
PPA
Performance
Project management
Proxy/VPN
Qt bugs
Qt6 compat
RSS
Search engine
Security
Temp folder
Themes
Translations
Triggers
Waiting diagnosis
Waiting info
Waiting upstream
Waiting web implementation
Watched folders
WebAPI
WebUI
autoCloseOldIssue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/qBittorrent#7540
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lgrn on GitHub (Jul 26, 2018).
Please provide the following information
qBittorrent version and Operating System
4.1.0 on Windows 10
What is the problem
When pausing a torrent manually in the GUI, the following is printed to the log:
(N) 2018-07-26T12:57:02 - 'REDACTED' reached the maximum ratio you set. Paused.What is the expected behavior
Since the pause actually had nothing to do with a maximum ratio (none is set), the log message should be more general:
(N) 2018-07-26T12:57:02 - 'REDACTED' was paused.This log message is still semantically correct, even if the pause occurred due to a maximum ratio being set, but it's also correct if the pause was done manually.
Steps to reproduce
Pause a torrent and look at the log file.
@lgrn commented on GitHub (Jul 26, 2018):
Most likely this is a simple string fix in
session.cpp, but I won't submit a fix since I'm not familiar with the logic.@lgrn commented on GitHub (Jul 26, 2018):
Sorry, I'm unable to reproduce this and it might be a completely different issue. I'll open a new issue if I manage to figure it out.