qbittorrent.log has overly specific and incorrect error message #7540

Closed
opened 2026-02-21 19:01:51 -05:00 by deekerman · 2 comments
Owner

Originally created by @lgrn on GitHub (Jul 26, 2018).

Please provide the following information

qBittorrent version and Operating System

4.1.0 on Windows 10

What is the problem

When pausing a torrent manually in the GUI, the following is printed to the log:

(N) 2018-07-26T12:57:02 - 'REDACTED' reached the maximum ratio you set. Paused.

What is the expected behavior

Since the pause actually had nothing to do with a maximum ratio (none is set), the log message should be more general:

(N) 2018-07-26T12:57:02 - 'REDACTED' was paused.

This log message is still semantically correct, even if the pause occurred due to a maximum ratio being set, but it's also correct if the pause was done manually.

Steps to reproduce

Pause a torrent and look at the log file.

Originally created by @lgrn on GitHub (Jul 26, 2018). **Please provide the following information** ### qBittorrent version and Operating System 4.1.0 on Windows 10 ### What is the problem When pausing a torrent manually in the GUI, the following is printed to the log: `(N) 2018-07-26T12:57:02 - 'REDACTED' reached the maximum ratio you set. Paused.` ### What is the expected behavior Since the pause actually had nothing to do with a maximum ratio (none is set), the log message should be more general: `(N) 2018-07-26T12:57:02 - 'REDACTED' was paused.` This log message is still semantically correct, even if the pause occurred due to a maximum ratio being set, but it's also correct if the pause was done manually. ### Steps to reproduce Pause a torrent and look at the log file.
Author
Owner

@lgrn commented on GitHub (Jul 26, 2018):

Most likely this is a simple string fix in session.cpp, but I won't submit a fix since I'm not familiar with the logic.

@lgrn commented on GitHub (Jul 26, 2018): Most likely this is a simple string fix in `session.cpp`, but I won't submit a fix since I'm not familiar with the logic.
Author
Owner

@lgrn commented on GitHub (Jul 26, 2018):

Sorry, I'm unable to reproduce this and it might be a completely different issue. I'll open a new issue if I manage to figure it out.

@lgrn commented on GitHub (Jul 26, 2018): Sorry, I'm unable to reproduce this and it might be a completely different issue. I'll open a new issue if I manage to figure it out.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/qBittorrent#7540
No description provided.