mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Wrong datatype error #1039
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#1039
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Goldenflamer on GitHub (Apr 27, 2022).
⚠️ Please verify that this bug has NOT been raised before.
🛡️ Security Policy
Description
There is an error causing a problem when saving certain values. Even if the datatype of the input is correct, there is an error saying "Wrong Datatype?" The error appears most consistently when adding a Steam API key via the settings but I have also seen it with other values. I am using the No Auth mode if that matters,
Steam key has the form A89A....... and is copied and pasted from steam directly, so it is 100% correct.
👟 Reproduction steps
Go to Settings and add a Steam API key
After inserting the Steam API key press save buttton
👀 Expected behavior
Steam API Key should be saved
😓 Actual Behavior
Error popup saying "Wrong data type?"
🐻 Uptime-Kuma Version
1.15.0
💻 Operating System and Arch
Windows 10 21H2 newest Updates as of posting date
🌐 Browser
Google Chrome 101.0.4951.41 64 bit
🐋 Docker Version
Docker Standalone 20.10.14
🟩 NodeJS Version
No response
📝 Relevant log output
No response
@chakflying commented on GitHub (Apr 27, 2022):
Saw this too, I think there is a bug with the authentication code when using No Auth mode, but I'm not sure exactly what's going on. Please try to enable auth and login again and the problem should go away.
@Goldenflamer commented on GitHub (Apr 27, 2022):
Yep you are right, working fine with auth
@Goldenflamer commented on GitHub (Apr 27, 2022):
The problem is that doubleCheckPassword(socket, currentPassword) is called when auth is disabled which should not be the case. There is only one occurrence where there is a check before it if authentication is disabled, maybe the check could be added to other occurrences as well. Or maybe the check is not working properly.