mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Not respecting UPTIME_KUMA_DISABLE_FRAME_SAMEORIGIN=1 #1668
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#1668
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Leah96xxx on GitHub (Dec 23, 2022).
⚠️ Please verify that this bug has NOT been raised before.
🛡️ Security Policy
Description
When launching Uptime Kuma from docker compose, it is not respecting UPTIME_KUMA_DISABLE_FRAME_SAMEORIGIN=1
I have tried using both 1 and true, but it ignores both, still showing "Refused to display 'https://kuma.[mydomain]' in a frame because it set 'X-Frame-Options' to 'sameorigin'." in the Chrome console.
Here is what I have in my docker-compose.yml:
👟 Reproduction steps
Launch Uptime Kuma as described above, check if iframe works, find error in console
👀 Expected behavior
iframe works
😓 Actual Behavior
Iframe refuses to connect and Chrome console reports "Refused to display 'https://kuma.[mydomain]' in a frame because it set 'X-Frame-Options' to 'sameorigin'."
🐻 Uptime-Kuma Version
1.18.5
💻 Operating System and Arch
Raspberry PI OS Lite 11 (bullseye), RasPI 4 ARM v8
🌐 Browser
Google Chrome 108.0.5359.125
🐋 Docker Version
Docker 20.10.18
🟩 NodeJS Version
No response
📝 Relevant log output
No response
@Leah96xxx commented on GitHub (Dec 23, 2022):
Ok, it somehow fixed itself. I have no clue what I did to fix it, but it now works in the iframe no problem.
@DonovanDiamond commented on GitHub (Jan 19, 2023):
If this occurs to anyone, please ensure you do
docker compose downanddocker compose upto load the new environment variable.@avishj commented on GitHub (Aug 14, 2023):
I ran into this same bug. I verified that the container is respecting the env flag, tried other browsers, chrome & firefox work properly, only edge doesn't work, any clues to what in edge's config would cause this?
Edit: Searched a bit more into this specific issue and running the html file that embeds the iframe via Live Server on VSCode works on Edge, but if I return that HTML page via a SpringBoot application running on a docker container and then try loading the HTML page on Edge, it no longer works. Not able to pin point what could be at fault here.
Edit #2: Nevermind, this fixed itself automatically after I changed some stuff related to the width and height of the iframe. I presume it definitely has nothing to do with the CSS changes but to do with the rm -f of the container and then rerunning the application serving the HTML, but then what surprises me here is that I have done this rm -f and run about 6-7 times previously and none of those fixed this weird issue. Maybe some sort of cache?
@gamer50082 commented on GitHub (Nov 14, 2023):
same issue but i dont use docker so how to fix
@chakflying commented on GitHub (Nov 15, 2023):
It's an environment variable. How you set the environment variable depends on your OS and how you start the application.
@karolysaysbye commented on GitHub (Apr 16, 2024):
Solution on Edge: Ctrl+ F5 or delete cookies and will be fine (you can also check in edge private mode first)
Ctrl+F5 will force the browser to retrieve the webpage from the server instead of loading it from the cache