mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
uptime value exceeds 100% #1793
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#1793
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @spac3monkey on GitHub (Jan 17, 2023).
⚠️ Please verify that this bug has NOT been raised before.
🛡️ Security Policy
Description
👟 Reproduction steps
I don't know.
👀 Expected behavior
The max. uptime value should be 100%.
😓 Actual Behavior
The max. uptime value is over 100%.
🐻 Uptime-Kuma Version
1.19.3
💻 Operating System and Arch
Raspbian bullseye
🌐 Browser
Google Chrome, Safari, Mozilla Firefox
🐋 Docker Version
2.14.1
🟩 NodeJS Version
No response
📝 Relevant log output
No response
@Computroniks commented on GitHub (Jan 17, 2023):
I think we just need a sanity check when displaying the uptime. I will look into implementing this tomorrow.
@chakflying commented on GitHub (Jan 17, 2023):
I think this most likely is because of inaccurate system clock (common for raspberry pis), and the time went backwards. The question is, is hiding the real problem by e.g. clamping the value to 100% a better solution?
@louislam commented on GitHub (Jan 17, 2023):
I cant find the old issue, but as @chakflying said, it is common issue for pi users.
Capping at 100% visually is good, but it will be hard to identify issues if we have make the calculation wrong in the future. I prefer to keep it as is for now.
@Computroniks commented on GitHub (Jan 18, 2023):
Not sure if this affects both the status page and the dashboard, I assume it would. I would suggest only capping it on the status page, the thing that is shown to the public. This way we don't have obvious public facing errors whilst still having the ability to check if we broke the calculations but the bug isn't visible to the public.
@louislam commented on GitHub (Jan 18, 2023):
@Computroniks good idea.
@Computroniks commented on GitHub (Jan 18, 2023):
This should have been fixed in #2635