Monitor shows google is down because of #2142 #2447

Closed
opened 2026-02-28 02:55:06 -05:00 by deekerman · 1 comment
Owner

Originally created by @SkwalExe on GitHub (Aug 8, 2023).

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

I installed the latest beta version and there seems to be an issue with PR #2142.

The request timeout is entered in seconds but seems to be used as milliseconds.

image

image

"Timeout of 48ms exceeded" should be "Timeout of 48000ms exceeded"

I made a quick look into the PR changes even though I dont code in JS often and I don't know the structure of the project etc, and I think the issue comes from this line. I may be wrong :

image

The * 1000 that converts seconds into milliseconds has been removed.

👟 Reproduction steps

  1. Use the latest beta version 1.23.0-beta.0
  2. Create a simple HTTPS monitor for google.com
  3. See the error

image

image

👀 Expected behavior

The requests should be successful

😓 Actual Behavior

See the error

image

image

🐻 Uptime-Kuma Version

1.23.0-beta.0

💻 Operating System and Arch

Ubuntu 22.04 x64

🌐 Browser

Browser doesn't matter

🐋 Docker Version

Not using docker

🟩 NodeJS Version

v16.20.0

📝 Relevant log output

No response

Originally created by @SkwalExe on GitHub (Aug 8, 2023). ### ⚠️ Please verify that this bug has NOT been raised before. - [X] I checked and didn't find similar issue ### 🛡️ Security Policy - [X] I agree to have read this project [Security Policy](https://github.com/louislam/uptime-kuma/security/policy) ### Description I installed the latest beta version and there seems to be an issue with PR #2142. The request timeout is entered in seconds but seems to be used as milliseconds. ![image](https://github.com/louislam/uptime-kuma/assets/69600456/e70d5042-4b25-4094-a19c-1a3f1a833641) ![image](https://github.com/louislam/uptime-kuma/assets/69600456/41a34ee2-0379-42e0-8e3b-f102c8bd6322) "Timeout of 48ms exceeded" should be "Timeout of 48000ms exceeded" I made a quick look into the PR changes even though I dont code in JS often and I don't know the structure of the project etc, and I think the issue comes from this line. I may be wrong : ![image](https://github.com/louislam/uptime-kuma/assets/69600456/8dcd4ca4-7b18-48aa-aa94-cbd7f7644c60) The * 1000 that converts seconds into milliseconds has been removed. ### 👟 Reproduction steps 1. Use the latest beta version 1.23.0-beta.0 2. Create a simple HTTPS monitor for google.com 3. See the error ![image](https://github.com/louislam/uptime-kuma/assets/69600456/83be58a0-d548-4cce-9fc9-6972311161a3) ![image](https://github.com/louislam/uptime-kuma/assets/69600456/41a34ee2-0379-42e0-8e3b-f102c8bd6322) ### 👀 Expected behavior The requests should be successful ### 😓 Actual Behavior See the error ![image](https://github.com/louislam/uptime-kuma/assets/69600456/83be58a0-d548-4cce-9fc9-6972311161a3) ![image](https://github.com/louislam/uptime-kuma/assets/69600456/41a34ee2-0379-42e0-8e3b-f102c8bd6322) ### 🐻 Uptime-Kuma Version 1.23.0-beta.0 ### 💻 Operating System and Arch Ubuntu 22.04 x64 ### 🌐 Browser Browser doesn't matter ### 🐋 Docker Version Not using docker ### 🟩 NodeJS Version v16.20.0 ### 📝 Relevant log output _No response_
deekerman 2026-02-28 02:55:06 -05:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@louislam commented on GitHub (Aug 8, 2023):

Thanks, did find the issue before, but forget to double check this bug before merged.
1.23.0-beta.1 will be release very soon.

@louislam commented on GitHub (Aug 8, 2023): Thanks, did find the issue before, but forget to double check this bug before merged. 1.23.0-beta.1 will be release very soon.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/uptime-kuma#2447
No description provided.