mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Monitor shows google is down because of #2142 #2447
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#2447
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SkwalExe on GitHub (Aug 8, 2023).
⚠️ Please verify that this bug has NOT been raised before.
🛡️ Security Policy
Description
I installed the latest beta version and there seems to be an issue with PR #2142.
The request timeout is entered in seconds but seems to be used as milliseconds.
"Timeout of 48ms exceeded" should be "Timeout of 48000ms exceeded"
I made a quick look into the PR changes even though I dont code in JS often and I don't know the structure of the project etc, and I think the issue comes from this line. I may be wrong :
The * 1000 that converts seconds into milliseconds has been removed.
👟 Reproduction steps
👀 Expected behavior
The requests should be successful
😓 Actual Behavior
See the error
🐻 Uptime-Kuma Version
1.23.0-beta.0
💻 Operating System and Arch
Ubuntu 22.04 x64
🌐 Browser
Browser doesn't matter
🐋 Docker Version
Not using docker
🟩 NodeJS Version
v16.20.0
📝 Relevant log output
No response
@louislam commented on GitHub (Aug 8, 2023):
Thanks, did find the issue before, but forget to double check this bug before merged.
1.23.0-beta.1 will be release very soon.