mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Status page shows "No/Bad Certificate" for self signed https servers instead of days #2497
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#2497
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Tragen on GitHub (Aug 19, 2023).
⚠️ Please verify that this bug has NOT been raised before.
🛡️ Security Policy
Description
I can check the uptime for https even if the server is serving a self signed certificate. But the status page show "No/Bad Certificate".
👟 Reproduction steps
Create a web server with a self signed certificate
👀 Expected behavior
Show the expiration date
😓 Actual Behavior
No/Bad Certificate
🐻 Uptime-Kuma Version
1.23.0
💻 Operating System and Arch
Debian bookworm
🌐 Browser
Firefox 116.0.3
🐋 Docker Version
No response
🟩 NodeJS Version
v18.13.0
📝 Relevant log output
No response
@CommanderStorm commented on GitHub (Aug 19, 2023):
As I read this, you are stating that the following is a bug, correct?
Selfsigned certificate => showing
No/Bad Certificateon the status page.Just that we are on the same page:
Selfsigned certificates are not valid certificates, unless you register your certificate's CA with the underlying system.
Have you registered your CA with your OS?
⇒ I think showing
No/Bad Certificatein the case of selfsigned certificates is what the results should be.Did I misunderstand the issue?
@Tragen commented on GitHub (Aug 20, 2023):
I haven't registered our CA with my OS.
But still it should show the days and can still show bad certificate.
@CommanderStorm commented on GitHub (Aug 20, 2023):
Why should it show the days? (I don't understand your rationale)
If you have not registered the CA, that is an invalid cert.
=> showing
No/Bad Certificateis intended=> I don't see the bug
Doing what you requested would be detrimental for other users:
Some webservers I know (nginx, traefik) deliver selfigned certs, if the website somehow (invalid letsencrypt configuration/...) cannot get a cert ⇒ an invalid certificate warning should be present, as the cert is invalid
@Tragen commented on GitHub (Aug 20, 2023):
Because the certificate is not invalid internally and we still need to replace the certificate when it expires.
You mix two different features. Showing days left and showing if it's a self signed / bad certificate.
You could still show: "Cert Exp: 25 days (No/Bad certificate)"
@CommanderStorm commented on GitHub (Aug 20, 2023):
IMO, that would be very confusing for users, as this would mix the messaging “your cert is invalid” and “your cert is alive for another x days”.
Editing the tag as suggested would not have obvious messaging to me.
It is for the OS you are running
uptime-kumaon.=> please register your CA there as well
@louislam commented on GitHub (Aug 20, 2023):
Checked the handling inside the dashboard, it indeed shows the days rather than bad cert. I agree that the status page is a bit not consistent.
Test case:
Ignore TLS/SSL error for HTTPS websites@CommanderStorm commented on GitHub (Aug 20, 2023):
Indeed that is a bug.
I did not check that checkbox when reproducing the bug
@CommanderStorm commented on GitHub (Aug 20, 2023):
Okay, I looked into it.
Currently, these systems (expiry + validity) are very entangled in the frontend and don't work well with the
Ignore TLS/SSL error for HTTPS websitesfeature.TO solve this, these are the goals Goals:
Only way I can see to achieve both is to introduces a new tag "valid Certificate" to the frontend.
I would like to have a way to manage which tags are displayed using a modal.
Such a change would involve a database migration.
I think the best way forward would be to introduce a bugfix for this in v2.0
I can work on this.
@Tragen commented on GitHub (Aug 23, 2023):
I would be happy to have it implemented into v2.0
@CommanderStorm commented on GitHub (Feb 20, 2024):
I currently am quite stressed with exams and a bachlor thesis
=> being able to work on this is unlikely
=> removing this "write-lock"