mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Gotify throws out error when sending down notification #3184
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#3184
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexbcberio on GitHub (Mar 11, 2024).
📑 I have found these related issues/pull requests
No solution is provided
The database engine used in this issue is MariaDB while I'm using the embedded one
🛡️ Security Policy
Description
Gotify notification provider does not send any "down" notification messages, "up" notification messages are sent correctly.
👟 Reproduction steps
Add Gotify provider and wait or force a "down" notification message
👀 Expected behavior
The down notification message should be correctly processed by Gotify
😓 Actual Behavior
Gotify server rejects the message
🐻 Uptime-Kuma Version
1.23.11
💻 Operating System and Arch
Ubuntu 22.04
🌐 Browser
any
🖥️ Deployment Environment
📝 Relevant log output
@chakflying commented on GitHub (Mar 11, 2024):
I think this is still the same issue as #1148. What is the database configuration used for the Gotify server?
@alexbcberio commented on GitHub (Mar 11, 2024):
Yes, as I already mentioned in the main message the issue is the same as on #1148.The difference is on the used database provider. I'm using the embedded sqlite (I haven't found any docs regarding how to set it up to MariaDB) while this other issue is using MariaDB as the database provider.Edit: the database provider for Gotify is MariaDB.
@CommanderStorm commented on GitHub (Mar 11, 2024):
So the same issue, correct?
If that is the case, we should definitely adapt the helptext for said monitor.
What do you think would be a good way to phrase this "oddity"
@alexbcberio commented on GitHub (Mar 11, 2024):
OMG, I have been messing up between Gotify database and Uptime-Kuma database all this time.
You're completely right, its the same issue. I have updated Gotify settings and its working ok.
Hmm, as for the phrasing I would add a notice telling "Ensure Gotify database connection url encoding matches the database encoding (utf8, utf8mb4, etc)". It might also be a good idea, if it were possible, to customize the "Test" message adding some known characters that cause issues.
Thanks for the fast support and replying so fast!
@CommanderStorm commented on GitHub (Mar 11, 2024):
That sounds like something you would need to set up gotify for (taking time out of my/another maintainers "time-budget" which could be used for other purposes).
Given that you already have this notification provider set up, would it be possible for you to contribute such a change and test that the character reproduces the case as intended?
Our contribution guide (how to set up a dev-environment) can be found here and the two relevant lines are:
github.com/louislam/uptime-kuma@bfd65ab6e3/src/components/notifications/Gotify.vue (L15)github.com/louislam/uptime-kuma@bfd65ab6e3/server/notification-providers/gotify.js (L11-L28)@alexbcberio commented on GitHub (Mar 11, 2024):
I will consider contributing to add this feature.
Thanks for the details!