mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Do not send notifications for UP notifications #3321
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#3321
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adriangalilea on GitHub (May 7, 2024).
📑 I have found these related issues/pull requests
This could work but the solution is complex, this should be implemented on the notification level.
🏷️ Feature Request Type
Settings
🔖 Feature description
New option to all notification "channels" (type in the UI)
Toggle option should read:
And that's it.
Telegram specific part
The only current available option is:
So either be annoyed by all successful checks or silent them all and miss important errors.
So my Telegram specific suggestion is that there should be an additional option that send all errors non-silently and send non-errors silently, this way I both know it's working and I don't get annoying notifications while knowing that if an error happens I'll get notified.
✔️ Solution
.
❓ Alternatives
No response
📝 Additional Context
No response
@CommanderStorm commented on GitHub (May 7, 2024):
Sort of in conflict (or at least interaction is unclear/difficult) with https://github.com/louislam/uptime-kuma/issues/508
I think adding a
disable_notificationtoggle from the telegram api and https://github.com/louislam/uptime-kuma/issues/508 are an alternative.Maybe a good alternative merging the approaches would be to have this as a mult-selection box (
notify for=>UP/DOWN/other).What do you think about these alternatives?
https://github.com/louislam/uptime-kuma/blob/master/server/notification-providers/telegram.js ↩︎
https://github.com/louislam/uptime-kuma/blob/master/src/components/notifications/Telegram.vue ↩︎
@adriangalilea commented on GitHub (May 7, 2024):
Completely missed this one, I searched for notification not alert.
This would be awesome yes.
I could totally help with telegram implementation once #508 is done, I've worked a lot with the telegram API and currently working full stack and typescript.
But as of now #508 blocks this.
@CommanderStorm commented on GitHub (May 7, 2024):
Just noticed that
disable_notificationis already an option we implement.=> don't think anything is needed in this department
What #508 needs should be pretty simple to implement.
The shared part of the notification dialog is here:
github.com/louislam/uptime-kuma@dbbc79a05a/src/components/NotificationDialog.vueNotifications in the backend are send here
github.com/louislam/uptime-kuma@dbbc79a05a/server/notification.js (L164-L170)@bilogic commented on GitHub (Aug 9, 2024):
Hi, I thought to check if we are facing the same problem:
I would like to know audibly and visually if
In order to have different sounds, I sent 1 and 2 into different group chats, but that created another issue: I can't easily see if the latest status is UP or DOWN.
After reading earlier comments, I thought it might make sense to have a 3rd chat that is always silent, but has all messages. Another alternative is to have the bot modify the title of the group chat with an icon?
Or is there some way we can meet all requirements using only a single group chat?