saveStatusPage socket handler does not use icon specified in payload if not base64-encoded #3326

Open
opened 2026-02-28 03:25:48 -05:00 by deekerman · 0 comments
Owner

Originally created by @jmolnar-comparative on GitHub (May 8, 2024).

I did not find any related issues

🛡️ Security Policy

Description

github.com/louislam/uptime-kuma@dbbc79a05a/server/socket-handlers/status-page-socket-handler.js (L139-L157)

config.icon is never again referenced, only config.logo

👟 Reproduction steps

write to the status page socket handler with a payload like:

{
    "icon": "/path/to/an/icon.svg"
}

or similar.

👀 Expected behavior

Status page should use provided icon.

😓 Actual Behavior

Status page keeps using whatever icon it is already using

🐻 Uptime-Kuma Version

1.23.13

💻 Operating System and Arch

Debian bookworm aarch64

🌐 Browser

Google Chrome 124.0.6367.119

🖥️ Deployment Environment

  • Runtime: Docker 20.10.21 / nodejs 20
  • Database: sqlite/embedded
  • Filesystem used to store the database on: Debian/ext4 SSD
  • number of monitors: 1

📝 Relevant log output

No response

Originally created by @jmolnar-comparative on GitHub (May 8, 2024). ### 📑 I have found these related issues/pull requests I did not find any related issues ### 🛡️ Security Policy - [X] I agree to have read this project [Security Policy](https://github.com/louislam/uptime-kuma/security/policy) ### Description https://github.com/louislam/uptime-kuma/blob/dbbc79a05a2036176c8b011401c915c0db3384ca/server/socket-handlers/status-page-socket-handler.js#L139-L157 `config.icon` is never again referenced, only `config.logo` ### 👟 Reproduction steps write to the status page socket handler with a payload like: ```json { "icon": "/path/to/an/icon.svg" } ``` or similar. ### 👀 Expected behavior Status page should use provided icon. ### 😓 Actual Behavior Status page keeps using whatever icon it is already using ### 🐻 Uptime-Kuma Version 1.23.13 ### 💻 Operating System and Arch Debian bookworm aarch64 ### 🌐 Browser Google Chrome 124.0.6367.119 ### 🖥️ Deployment Environment - Runtime: Docker 20.10.21 / nodejs 20 - Database: sqlite/embedded - Filesystem used to store the database on: Debian/ext4 SSD - number of monitors: 1 ### 📝 Relevant log output _No response_
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/uptime-kuma#3326
No description provided.