mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
saveStatusPage socket handler does not use icon specified in payload if not base64-encoded #3326
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#3326
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jmolnar-comparative on GitHub (May 8, 2024).
📑 I have found these related issues/pull requests
I did not find any related issues
🛡️ Security Policy
Description
github.com/louislam/uptime-kuma@dbbc79a05a/server/socket-handlers/status-page-socket-handler.js (L139-L157)config.iconis never again referenced, onlyconfig.logo👟 Reproduction steps
write to the status page socket handler with a payload like:
or similar.
👀 Expected behavior
Status page should use provided icon.
😓 Actual Behavior
Status page keeps using whatever icon it is already using
🐻 Uptime-Kuma Version
1.23.13
💻 Operating System and Arch
Debian bookworm aarch64
🌐 Browser
Google Chrome 124.0.6367.119
🖥️ Deployment Environment
📝 Relevant log output
No response