Old code re-introduced into notification.js #34

Closed
opened 2026-02-28 01:32:27 -05:00 by deekerman · 2 comments
Owner

Originally created by @TheGuyDanish on GitHub (Jul 13, 2021).

I looked at notification.js following the new release and old code that I had removed as part of the Discord rework seems to have been reintroduced in 3e4a98b.

notification.js#L95,L177-187

May cause an error due to missed dependencies if a Discord notification is invoked.

Originally created by @TheGuyDanish on GitHub (Jul 13, 2021). I looked at notification.js following the new release and old code that I had removed as part of the Discord rework seems to have been reintroduced in 3e4a98b. notification.js#L95,L177-187 May cause an error due to missed dependencies if a Discord notification is invoked.
Author
Owner

@louislam commented on GitHub (Jul 13, 2021):

Ops, my mistake when merging the conflict

@louislam commented on GitHub (Jul 13, 2021): Ops, my mistake when merging the conflict
Author
Owner

@louislam commented on GitHub (Jul 13, 2021):

fixed in 1.0.3

@louislam commented on GitHub (Jul 13, 2021): fixed in 1.0.3
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/uptime-kuma#34
No description provided.