mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Remove monitor warning in logs under maintenance #3406
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#3406
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Lurikbolding on GitHub (Jun 12, 2024).
📑 I have found these related issues/pull requests
I have not found related issues
🏷️ Feature Request Type
Other
🔖 Feature description
I have a monitor to check a service only 2h a day, so it is 22h a day on maintenance status.
But even on maintenance status, there is line of warning in log :
2024-06-12T12:30:22+02:00 [MONITOR] WARN: Monitor #14 'NameMonitor': Under Maintenance | Type: keyword
As there is a lot theses warning line, i cannot find other useful line in log (ex : error of database, timeout of database).
✔️ Solution
Could we have a setting in monitor maintenance to avoid logging event.
a kind of switch in the maintenance setting : "do not log event when maintenance is on"
❓ Alternatives
I did not find alternative
📝 Additional Context
I would not have these lines id log :
2024-06-12T12:30:22+02:00 [MONITOR] WARN: Monitor #14 'Monitor Name': Under Maintenance | Type: keyword
@CommanderStorm commented on GitHub (Jun 12, 2024):
Don't think that we should add a setting for this or log this at a lower level.
Someone might be expecting a ping and not getting it otherwise.
Don't think that settings controlling how we log is a good idea. Forking the controll flow like this is not maintainable.
Please use a log aggregator like grafana Loki (or other software) to filter your logs instead
@Lurikbolding commented on GitHub (Jun 15, 2024):
Ok, i understand that using grafana could help.
But as the monitor is under maintenance, why we need to ping these server?
as i understand, the monitor mode is to shut down any activity of the monitor?
@CommanderStorm commented on GitHub (Jun 15, 2024):
We don't consider maintenance to be such a common occurrence => handling it as a short circuit is efficient enough for our use case. CPU impact should be minimal compared to more error prown alternatives like pausing the monitor
@Lurikbolding commented on GitHub (Jun 15, 2024):
Ok, thank you for your quick answer.