mirror of
https://github.com/louislam/uptime-kuma.git
synced 2026-03-02 22:57:00 -05:00
Minimum check interval is only enforced on the frontend #368
Labels
No labels
A:accessibility
A:api
A:cert-expiry
A:core
A:dashboard
A:deployment
A:documentation
A:domain expiry
A:incidents
A:maintenance
A:metrics
A:monitor
A:notifications
A:reports
A:settings
A:status-page
A:ui/ux
A:user-management
Stale
ai-slop
blocked
blocked-upstream
bug
cannot-reproduce
dependencies
discussion
duplicate
feature-request
feature-request
good first issue
hacktoberfest
help
help wanted
house keeping
invalid
invalid-format
invalid-format
question
releaseblocker 🚨
security
spam
type:enhance-existing
type:new
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/uptime-kuma#368
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lrstanley on GitHub (Oct 9, 2021).
Describe the bug
A user can submit an http request with an extremely low check interval (say...
0.01s), as the limit is only enforced on the frontend side of the service. This can lead to a potential denial-of-service attack by overloading the service, and potentially causing service disruption to the target monitored website.To Reproduce
Steps to reproduce the behavior: Either submit an http request with the lower value, or use Chrome debugging tools to remove the
min="<int>"andtype="number"attributes, which will allow you to still lower the value via the UI.Was able to replicate this on: demo.uptime.kuma.pet.
Expected behavior
The frontend and backend should both enforce this behavior, to prevent unwanted or malicious behavior.
@louislam commented on GitHub (Oct 9, 2021):
Thank you for your report.
Yes, the input validations are frontend only currently. In the current stage, it should not be a big problem, as there is only one user account only. And that's one of reasons why multiple users features (#128) is not implemented yet.
However, it did hurt the demo site though, I just fixed it quickly:
github.com/louislam/uptime-kuma@5c89562650Would be appreciated if you could send the security issue to the email first.
https://github.com/louislam/uptime-kuma/security/policy
@CommanderStorm commented on GitHub (Jul 26, 2023):
@lrstanley I think this issue is resolved:

Which is checked on the server here:
github.com/louislam/uptime-kuma@6413d4cbdf/server/model/monitor.js (L1455-L1463)=> Could you close this issue?