mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-02 22:57:18 -05:00
Env-Variable - Renaming SMTP_EXPLICIT_TLS #1194
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1194
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sando38 on GitHub (Jan 11, 2022).
Hello there,
reporting this, because I missinterpreted it. According to RFC8314 (https://datatracker.ietf.org/doc/html/rfc8314#section-3.3) implicit TLS is used for port 465.
However, to force tls with environment variables in the smtp settings, I have to set:
SMTP_EXPLICIT_TLS=true -> which would actually imply STARTTLS.
So, either I suggest renaming the environment variable into:
SMTP_IMPLICIT_TLS or
SMTP_FORCE_TLS
to avoid confusion.
NB: Thanks for your great service with providing vaultwarden. It is a great tool.
Wishing a nice day!
@BlackDex commented on GitHub (Jan 11, 2022):
This will be a wont fix, since this would lead to a lot of invalid configurations. A lot of people have this configured using that variable and we would not like to break those. Also, adding a second variable and keeping the current one will probably lead to confusion or also some weird issues.
There is already a mentioning of the wrongly named variable here: https://github.com/dani-garcia/vaultwarden/blob/main/.env.template#L335
Also see #851 (which this ticket is a duplicate of)