mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-02 22:57:18 -05:00
email address not supporting international domain names #1596
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1596
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Sasaxxxx on GitHub (May 7, 2023).
Subject of the issue
Problem starts when using international domain names. fx. xxxx@xn--gr-wla37a.com (xxxx@gršć.com)
When user account is created using xxxx@gršć.com (in version of VaultWarden 1.25.2), now VaultWarden v- 1.28.1 do not support this email address.
When this email address is typed in the VaultWarden Web Vault, Error message is shown: " Input is not an email address."
Deployment environment
Error message: "Generation Failed"
Install method: Docker on Synology server
Clients used:
WebVault, desktop, IOS
Reverse proxy and version:
MySQL/MariaDB or PostgreSQL version:
Other relevant details:
Steps to reproduce
2.. version updated to 1.28.1
Expected behaviour
Actual behaviour
Troubleshooting data
@BlackDex commented on GitHub (May 7, 2023):
Is the client converting this before it is sending this?
@Sasaxxxx commented on GitHub (May 7, 2023):
it was working for over a year. Today I find out I could not log in on IOS App. Updated VaultWarden form 1.25.1 to 1.28.1 with results as reported.
@Sasaxxxx commented on GitHub (May 7, 2023):
I can see now following:
Actual behaviour:
LogIn on VaultWarden Web Vault. Email: xxxx@@gršć.com
request for MasterPasword:
underneeth of the logIn button, stated: "Logging in as xxxx@xn--gr-wla37a.com"
so i guess it will try to login as user xxxx@xn--gr-wla37a.com (which is not a user xxxx@@gršć.com). can system tell a difference and convert domains in right way?
@BlackDex commented on GitHub (May 7, 2023):
Vaultwarden doesn't convert the address. So it could be that the new clients convert them before sending it to the server.
@Sasaxxxx commented on GitHub (May 7, 2023):
is VaultWarden Web Vault server part?
@BlackDex commented on GitHub (May 7, 2023):
No, that is client. But it could be that Bitwarden changed something. I'm not sure.
@BlackDex commented on GitHub (May 7, 2023):
On a quick look, I'm afraid we can't fix this on our side that easily.
It looks like the web-vault doesn't seem to support this anymore for some reason.
On the web-vault I get a message that it needs to be a valid email address.
It seems to be not working anymore since v1.26.0 already (Which uses v2022.12.0 as web-vault).
@BlackDex commented on GitHub (May 8, 2023):
I also think we can't fix this on the server side.
The reason is, the username (mail address) is linked to the hashed password and master-key.
Changing the mail-address, or trying to match the password-hash on the unicode domain will not work.
I suggest to revert back to v1.25.2, change all mail address to use the punycode address via the web-vault and upgrade after all the users have changed it.
It's not something we can fix unfortunately.