mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-03-03 00:46:57 -05:00
JWT not sent to API after login on Firefox 111 in HTTPS-only mode #130
Labels
No labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
question
security
support
upstream issue
waiting for reply
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vikunja-go-vikunja#130
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @eduarrrd on GitHub (Mar 19, 2023).
Description
Vikunja does not allow me to log in using Firefox 111 (possibly earlier) using the HTTPS-only mode. Disabling the HTTPS-only mode causes login to succeed. It appears that it can be re-enabled afterwards and things keep working but I did not investigate.
It works in Chrome 112 with Chrome's default config.
The following is gathered using the Firefox Devtools.
Login succeeds:
Request
gets response
However, the subsequent call to
/api/v1/userdoesn't supply the JWT:resulting in a 401 response:
In the js console I see the following relevant lines:
Vikunja Frontend Version
0.20.5+45-846de369f2
Vikunja API Version
Whatever try.vikunja.org is using at the time of this post.
Browser and version
Firefox 111
Can you reproduce the bug on the Vikunja demo site?
Yes
Screenshots
No response
@zero-thermo commented on GitHub (Mar 19, 2023):
I am also ran into a similar issue, and lost access to Vikunja via https://vikunja.tld after upgrading to Firefox 111. I'm using a docker-compose setup with Nginx Proxy Manager.
I was able to restore access to my data with these Nginx Proxy Manager configs
Despite restoring access, https://vikunja.tld/api/v1/ now displays this message:
@davidmehren commented on GitHub (Mar 20, 2023):
The Firefox 111 release notes say:
That sounds like it could be related.
@kolaente commented on GitHub (Mar 20, 2023):
This does sound like it might be the cause here. On try the api request is not a cross-origin one though. Not sure what to make of this.
@kolaente commented on GitHub (Mar 20, 2023):
Looks like this is actually a spec change: https://github.com/mdn/content/issues/22533
So it will stop working in Chrome as well once they include the spec update.
@kolaente commented on GitHub (Mar 20, 2023):
I just tested this in Firefox Dev 112 and it seems to work fine. Can anyone else confirm this?
@kolaente commented on GitHub (Mar 20, 2023):
Now also tested in Firefox 111 and it seems to work there as well. (Both on my NixOS)
@kolaente commented on GitHub (Mar 20, 2023):
Okay so I kind of reproduced it in Firefox dev 112:
API_URLsaved there: It probably starts withhttpinstead ofhttps.Now, I wonder why it saves
httpin the first place?I was able to fix this by explicitely setting the
API_URLfor the frontend to the full api url includinghttps://..(tested on try). @eduarrrd @zero-thermo can you check if it works for you on try?To me, this kind of looks like a bug in Firefox. It seems like other people noticed as well but in that bug report it appears fixed?
@kolaente commented on GitHub (Mar 20, 2023):
Opened a follow-up bug report to clarify if this has been fixed in Firefox and just not yet released or if it needs a new fix: https://bugzilla.mozilla.org/show_bug.cgi?id=1823502
@zero-thermo commented on GitHub (Mar 20, 2023):
https://try.vikunja.ioworks, but also displays the samemissing or malformed jwtas my ownhttp://vikunja.tld/api/v1instance. Despite that error message, basic operations seems to be functioning (creating tasks, changing dates, marking as done). Same results whether usinghttp://orhttps://in myVIKUNJA_API_URLandVIKUNJA_SERVICE_FRONTENDURLenvironment variables.Thanks for being a responsive developer, and for your continued work on this app.