mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-03-03 00:46:57 -05:00
Deleting Task Doesn't Update Timestamp #49
Labels
No labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
question
security
support
upstream issue
waiting for reply
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vikunja-go-vikunja#49
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ducky6944 on GitHub (May 15, 2022).
I may be wrong, but it seems that deleting a task doesn't update the tasklist
updatedtimestamp. Creating a new task does.I'm writing a script that uses the api to send notifications when a list has been
updated. Maybe I'm missing something. I'm not a developer and this may be r/badcode lol.example code:
@Ducky6944 commented on GitHub (May 16, 2022):
Adding or Removing labels also doesn't seem to change the task['updated'] value like Priority and Descriptions changes do.
@kolaente commented on GitHub (May 18, 2022):
That's correct. Mostly because they are not updated automatically and I didn't explicitly built it so they all update. I think this is somewhere between bug and feature, but definitely undefined behaviour.
If you're up to it, I'd appreciate a PR! Might take some time until I get around to fix it.
@Ducky6944 commented on GitHub (May 18, 2022):
Hey thanks for the response. I will certainly look into it and see if it's something I am comfortable tackling, when I get a free minute. I'm not a dev and I don't want to spaghetti code your project and just create more work for you, combing through a terrible pull request lol. But if I can I absolutely will try. Thanks!
@kolaente commented on GitHub (May 18, 2022):
Sounds great! At least you know more python than I do so I wouldn't say you're not a Dev :)
What you're looking for is this line: https://github.com/go-vikunja/api/blob/main/pkg/models/task_assignees.go#L149
That needs to be added in the relevant places of similar methods.
@kolaente commented on GitHub (Mar 14, 2023):
This is now implemented.