mirror of
https://github.com/ArnoldSmith86/virtualtabletop.git
synced 2026-03-02 22:57:02 -05:00
thisButton and thisID are not reset in a CALL #180
Labels
No labels
PCIO compatibility
Validator
automated testing
bug
documentation
duplicate
editor
enhancement
enhancement
library
library
maintenance
needs legacy server
pile related
reported client crash
routine operations
user interface
widget properties
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/virtualtabletop#180
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rogerl50 on GitHub (Apr 8, 2021).
Originally assigned to: @ArnoldSmith86 on GitHub.
When one widget calls a routine in another widget, the
thisButtoncollection and thethisIDvariable continue to refer to the (original) caller. This behavior should probably be changed.Additionally, now that any widget can have a
clickRoutine, the name ofthisButtonshould perhaps be changed tothisWidget; however, this would require a fileUpdater change.@ArnoldSmith86 commented on GitHub (Apr 8, 2021):
I agree that
thisIDandthisButtonshould point to the callee.I also agree with renaming but later.