mirror of
https://github.com/ArnoldSmith86/virtualtabletop.git
synced 2026-03-02 22:57:02 -05:00
Show game + variant in <title> #262
Labels
No labels
PCIO compatibility
Validator
automated testing
bug
documentation
duplicate
editor
enhancement
enhancement
library
library
maintenance
needs legacy server
pile related
reported client crash
routine operations
user interface
widget properties
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/virtualtabletop#262
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @minotalen on GitHub (Jun 3, 2021).
Title currently only states "VirtualTabletop.io".
I think a fitting syntax could be "name of game (name of variant) - VirtualTabletop.io". Not really a functional requirement, just nice to have with multiple open VTT tabs.
@robartsd commented on GitHub (Jun 3, 2021):
Room name would also be a good candidate to put in the title (particularly if the room name is not auto-generated).
@96LawDawg commented on GitHub (Jun 3, 2021):
We also still need a favicon.
@bjalder26 commented on GitHub (Jun 3, 2021):
Designed or uploaded and inserted in the HTML?
@96LawDawg commented on GitHub (Jun 3, 2021):
Designed.
@bjalder26 commented on GitHub (Jun 3, 2021):
Did someone say design contest?
@robartsd commented on GitHub (Jun 6, 2021):
Difficulty with this specific request is I don't think you can get the name of the game/variant loaded from the library from the room state.
I'm thinking about putting together a PR that will put roomID in the title and allow for url parameters to customize the title. Customizing the title for PR test servers is also something I'm thinking about here.
@96LawDawg commented on GitHub (Jun 6, 2021):
I can definitely get behind that idea. I agree that it would be hard, if not impossible, to get the game name. But the room name would be really useful also.
@robartsd commented on GitHub (Apr 14, 2023):
#1566 intended to add game name, but got changed to simply add room name due to difficulties adding game name.
@96LawDawg commented on GitHub (Apr 14, 2023):
And adding the game name would still be a nice addition, but it wasn't worth holding that PR up anymore for that. Thanks for re-opening this. Also the comments in #1566 about allowing customization in the json.config for user systems is also still a good idea.