mirror of
https://github.com/ArnoldSmith86/virtualtabletop.git
synced 2026-03-02 22:57:02 -05:00
Faces and changeRoutine do not work well together. #390
Labels
No labels
PCIO compatibility
Validator
automated testing
bug
documentation
duplicate
editor
enhancement
enhancement
library
library
maintenance
needs legacy server
pile related
reported client crash
routine operations
user interface
widget properties
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/virtualtabletop#390
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @96LawDawg on GitHub (Nov 5, 2021).
I am having a problem with a
changeRoutineand faces in the same widget. I made a basic widget where as the faces change, the text changes from -- to A to B to C. I tried use achangeRoutineto feed that value to another widget. But the other widget lags behind by one click. Demo room at https://virtualtabletop.io/wdyq. I used this code on the widgets on the left:@bjalder26 found a solution using this code for the widgets on the right:
But there is no reason that my code shouldn't work except for the order in which things activate. @bjalder26 suggests that activeFace updates first, then the changeRoutine fires, then the property updates.
@96LawDawg commented on GitHub (Nov 5, 2021):
This may be related to #536
@robartsd commented on GitHub (Nov 5, 2021):
I have not analyzed the relevant code recently, but my guess is that changing the
activeFacetriggerschangeRoutinebefore the properties from the face are copied to the widget. The routine runs, then the properties from the face are copied to the widget without triggeringchangeRoutneagain.@ArnoldSmith86 commented on GitHub (Nov 25, 2021):
I would like to merge #536 when we have compatibility servers for breaking changes working. After that is merged, a
changeRoutinewould still not trigger for the properties inside the face but aGETinside anactiveFaceChangeRoutineshould return the expected value.