starred/virtualtabletop

Fork 0

mirror of https://github.com/ArnoldSmith86/virtualtabletop.git synced 2026-03-02 22:57:02 -05:00

CSS dynamic variables #495

New issue

Closed

opened 2026-02-20 10:18:05 -05:00 by deekerman · 6 comments

deekerman commented

2026-02-20 10:18:05 -05:00

Owner

Originally created by @96LawDawg on GitHub (Mar 14, 2022).

Originally assigned to: @ArnoldSmith86 on GitHub.

When I was testing the new dragging property, I set up a widget with the following css:

"css": {
    "default": {
      "background-color": "${PROPERTY dragColor}"
    }
  }

dragColor was a custom property set on the widget by another routine. It was either the playerColor or it was null. The css handled the switch from null to the color just fine. But when the dragColor changed back to null, the css dynamic variable didn't react. If instead of going to null, I set the dragColor to "white", it worked fine. If I set the dragColor to false, it worked fine.

Refreshing the browser window when dragColor was null did reset the background. Not sure if this is intended behavior or an issue when css dynamic variables encounter a null. @robartsd ?

Originally created by @96LawDawg on GitHub (Mar 14, 2022). Originally assigned to: @ArnoldSmith86 on GitHub. When I was testing the new `dragging` property, I set up a widget with the following css: ```JSON "css": { "default": { "background-color": "${PROPERTY dragColor}" } } ``` `dragColor` was a custom property set on the widget by another routine. It was either the `playerColor` or it was null. The css handled the switch from null to the color just fine. But when the `dragColor` changed back to null, the css dynamic variable didn't react. If instead of going to null, I set the `dragColor` to "white", it worked fine. If I set the `dragColor` to false, it worked fine. Refreshing the browser window when `dragColor` was null did reset the background. Not sure if this is intended behavior or an issue when css dynamic variables encounter a null. @robartsd ?

deekerman

2026-02-20 10:18:05 -05:00

closed this issue
added the
bug

widget properties
labels

deekerman commented

2026-02-20 10:18:06 -05:00

Author

Owner

@robartsd commented on GitHub (Mar 14, 2022):

@ArnoldSmith86 wrote the code for CSS dynamic variables, so he would be more familiar with how it works. Based on what you describe, my guess is that properties being deleted from a widget (setting a property to null causes it to be deleted) are not checked to see if those properties are used in the CSS. I'm pretty sure that this is unintended, since the display should always be the same after a refresh.

@robartsd commented on GitHub (Mar 14, 2022): @ArnoldSmith86 wrote the code for CSS dynamic variables, so he would be more familiar with how it works. Based on what you describe, my guess is that properties being deleted from a widget (setting a property to `null` causes it to be deleted) are not checked to see if those properties are used in the CSS. I'm pretty sure that this is unintended, since the display should always be the same after a refresh.

deekerman commented

2026-02-20 10:18:06 -05:00

Author

Owner

@robartsd commented on GitHub (Mar 15, 2022):

I'm also experiencing a problem using CSS dynamic variables if the CSS property for a card comes from the deck.

@robartsd commented on GitHub (Mar 15, 2022): I'm also experiencing a problem using CSS dynamic variables if the CSS property for a card comes from the deck.

deekerman commented

2026-02-20 10:18:06 -05:00

Author

Owner

@ArnoldSmith86 commented on GitHub (Mar 15, 2022):

I'm also experiencing a problem using CSS dynamic variables if the CSS property for a card comes from the deck.

Do you have an example? And is it fixed in #1148?

@ArnoldSmith86 commented on GitHub (Mar 15, 2022): > I'm also experiencing a problem using CSS dynamic variables if the CSS property for a card comes from the deck. Do you have an example? And is it fixed in #1148?

deekerman commented

2026-02-20 10:18:07 -05:00

Author

Owner

@robartsd commented on GitHub (Mar 15, 2022):

I'm working on transportationDeck for Fun with Transit. css property in cardTypes or cardDefaults does not work, but same property set directly in the card does work. I'll work on a test case.

@robartsd commented on GitHub (Mar 15, 2022): I'm working on `transportationDeck` for [Fun with Transit](https://virtualtabletop.io/T2R_NewYork). `css` property in `cardTypes` or `cardDefaults` does not work, but same property set directly in the card does work. I'll work on a test case.

deekerman commented

2026-02-20 10:18:07 -05:00

Author

Owner

@ArnoldSmith86 commented on GitHub (Mar 15, 2022):

If it works in the PR, we don't need a test case, I guess.

@ArnoldSmith86 commented on GitHub (Mar 15, 2022): If it works in the PR, we don't need a test case, I guess.

deekerman commented

2026-02-20 10:18:07 -05:00

Author

Owner

@robartsd commented on GitHub (Mar 15, 2022):