starred/virtualtabletop
1
0
Fork 0
mirror of https://github.com/ArnoldSmith86/virtualtabletop.git synced 2026-03-02 22:57:02 -05:00
Code Issues 279 Projects Packages Wiki Activity

Holder Events #521

New issue
Open
opened 2026-02-20 10:18:20 -05:00 by deekerman · 3 comments
deekerman commented 2026-02-20 10:18:20 -05:00
Owner
Copy link

Originally created by @robartsd on GitHub (May 13, 2022).

We know that holder events don't work as we want them to, but we haven't really defined how we want them to work. This is a draft of what I think should happen.

Widget dragged from HolderA to HolderB

  1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag
  2. Widget.parent set to null
  3. call HolderA.beforeLeaveRoutine (mitigate that leave routine no longer fires twice by adding beforeLeaveRoutine that calls leaveRoutine via fileupdater)
  4. mousemove/touchmove events move widget - HolderA is no longer hoverTarget
  5. change Widget properties based on HolderA.childrenPerOwner and HolderA.onLeave
  6. call HolderA.leaveRoutine
  7. mousemove/touchmove events move widget - HolderB becomes hoverTarget
  8. mouseup/touchend event completes the move
  9. Widget.parent set to HolderB.id
  10. change Widget properties based on HolderB.childrenPerOwner, HolderB.onEnter, HolderB.alignChildren
  11. resolve piles
  12. call HolderA.afterLeaveRoutine
  13. call HolderB.enterRoutine

Widget dragged into HolderB

  1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag
  2. mousemove/touchmove events move widget - HolderB becomes hoverTarget
  3. mouseup/touchend event completes the move
  4. Widget.parent set to HolderB.id
  5. change Widget properties based on HolderB.childrenPerOwner, HolderB.onEnter, HolderB.alignChildren
  6. resolve piles
  7. call HolderB.enterRoutine

Widget dragged out of HolderA

  1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag
  2. Widget.parent set to null
  3. call HolderA.beforeLeaveRoutine
  4. mousemove/touchmove events move widget - HolderA is no longer hoverTarget
  5. change Widget properties based on HolderA.childrenPerOwner and HolderA.onLeave
  6. call HolderA.leaveRoutine
  7. mouseup/touchend event completes the move
  8. resolve piles
  9. call HolderA.afterLeaveRoutine

Widget dragged within HolderA (Holder is always hoverTarget during the move)

  1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag
  2. Widget.parent set to null
  3. call HolderA.beforeLeaveRoutine
  4. mouseup/touchend event completes the move
  5. Widget.parent set to HolderA.id
  6. change Widget properties based on HolderA.childrenPerOwner, HolderA.onEnter, HolderA.alignChildren
  7. resolve piles
  8. call HolderA.leaveCancelledRoutine with flag indicating that leaveRoutine was not called

Widget dragged out of HolderA, but returns to HolderA before being dropped

  1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag
  2. Widget.parent set to null
  3. call HolderA.beforeLeaveRoutine
  4. mousemove/touchmove events move widget - HolderA is no longer hoverTarget
  5. change Widget properties based on HolderA.childrenPerOwner and HolderA.onLeave
  6. call HolderA.leaveRoutine
  7. mousemove/touchmove events move widget - HolderA becomes hoverTarget
  8. mouseup/touchend event completes the move
  9. Widget.parent set to HolderA.id
  10. change Widget properties based on HolderA.childrenPerOwner, HolderA.onEnter, HolderA.alignChildren
  11. resolve piles
  12. call HolderA.leaveCancelledRoutine with flag indicating that leaveRoutine was called

MOVE Widget from HolderA to HolderB

  1. MOVE encounted moving Widget
  2. change Widget properties based on HolderA.childrenPerOwner and HolderA.onLeave
  3. call HolderA.leaveRoutine with flag indicating that widget was moved by a routine
  4. Widget.parent set to HolderB.id
  5. change Widget properties based on HolderB.childrenPerOwner, HolderB.onEnter
  6. position Widget in holder regardless of HolderB.alignChildren
  7. resolve piles
  8. call HolderA.afterLeaveRoutine with flag indicating that widget was moved by a routine
  9. call HolderB.enterRoutine with flag indicating that widget was moved by a routine
  10. resume processing routine where MOVE was encountered

MOVEXY Widget from HolderA

  1. MOVEXY encounted moving Widget
  2. change Widget properties based on HolderA.childrenPerOwner and HolderA.onLeave
  3. call HolderA.leaveRoutine with flag indicating that widget was moved by a routine
  4. Widget.parent set to null
  5. set Widget position
  6. resolve piles
  7. call HolderA.afterLeaveRoutine with flag indicating that widget was moved by a routine
  8. resume processing routine where MOVEXY was encountered

MOVE Widget to HolderB (after collection support is added for MOVE)

  1. MOVE encounted moving Widget
  2. Widget.parent set to HolderB.id
  3. change Widget properties based on HolderB.childrenPerOwner, HolderB.onEnter
  4. position Widget in holder regardless of HolderB.alignChildren
  5. resolve piles
  6. call HolderB.enterRoutine with flag indicating that widget was moved by a routine
  7. resume processing routine where MOVE was encountered
Originally created by @robartsd on GitHub (May 13, 2022). We know that holder events don't work as we want them to, but we haven't really defined how we want them to work. This is a draft of what I think should happen. ### Widget dragged from HolderA to HolderB 1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag 2. Widget.`parent` set to null 3. call HolderA.`beforeLeaveRoutine` (mitigate that leave routine no longer fires twice by adding `beforeLeaveRoutine` that calls `leaveRoutine` via fileupdater) 4. mousemove/touchmove events move widget - HolderA is no longer hoverTarget 5. change Widget properties based on HolderA.`childrenPerOwner` and HolderA.`onLeave` 6. call HolderA.`leaveRoutine` 7. mousemove/touchmove events move widget - HolderB becomes hoverTarget 8. mouseup/touchend event completes the move 9. Widget.`parent` set to HolderB.`id` 10. change Widget properties based on HolderB.`childrenPerOwner`, HolderB.`onEnter`, HolderB.`alignChildren` 11. resolve piles 12. call HolderA.`afterLeaveRoutine` 13. call HolderB.`enterRoutine` ### Widget dragged into HolderB 1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag 7. mousemove/touchmove events move widget - HolderB becomes hoverTarget 8. mouseup/touchend event completes the move 9. Widget.`parent` set to HolderB.`id` 10. change Widget properties based on HolderB.`childrenPerOwner`, HolderB.`onEnter`, HolderB.`alignChildren` 11. resolve piles 12. call HolderB.`enterRoutine` ### Widget dragged out of HolderA 1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag 2. Widget.`parent` set to null 3. call HolderA.`beforeLeaveRoutine` 4. mousemove/touchmove events move widget - HolderA is no longer hoverTarget 5. change Widget properties based on HolderA.`childrenPerOwner` and HolderA.`onLeave` 6. call HolderA.`leaveRoutine` 8. mouseup/touchend event completes the move 9. resolve piles 12. call HolderA.`afterLeaveRoutine` ### Widget dragged within HolderA (Holder is always hoverTarget during the move) 1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag 2. Widget.`parent` set to null 3. call HolderA.`beforeLeaveRoutine` 8. mouseup/touchend event completes the move 10. Widget.`parent` set to HolderA.`id` 11. change Widget properties based on HolderA.`childrenPerOwner`, HolderA.`onEnter`, HolderA.`alignChildren` 12. resolve piles 13. call HolderA.`leaveCancelledRoutine` with flag indicating that `leaveRoutine` was not called ### Widget dragged out of HolderA, but returns to HolderA before being dropped 1. mousedown/touchstart followed by mousemove/touchmove triggers beginning of drag 2. Widget.`parent` set to null 3. call HolderA.`beforeLeaveRoutine` 4. mousemove/touchmove events move widget - HolderA is no longer hoverTarget 5. change Widget properties based on HolderA.`childrenPerOwner` and HolderA.`onLeave` 6. call HolderA.`leaveRoutine` 7. mousemove/touchmove events move widget - HolderA becomes hoverTarget 8. mouseup/touchend event completes the move 9. Widget.`parent` set to HolderA.`id` 10. change Widget properties based on HolderA.`childrenPerOwner`, HolderA.`onEnter`, HolderA.`alignChildren` 11. resolve piles 12. call HolderA.`leaveCancelledRoutine` with flag indicating that `leaveRoutine` was called ### `MOVE` Widget from HolderA to HolderB 1. MOVE encounted moving Widget 2. change Widget properties based on HolderA.`childrenPerOwner` and HolderA.`onLeave` 3. call HolderA.`leaveRoutine` with flag indicating that widget was moved by a routine 4. Widget.`parent` set to HolderB.`id` 5. change Widget properties based on HolderB.`childrenPerOwner`, HolderB.`onEnter` 6. position Widget in holder regardless of HolderB.`alignChildren` 7. resolve piles 8. call HolderA.`afterLeaveRoutine` with flag indicating that widget was moved by a routine 9. call HolderB.`enterRoutine` with flag indicating that widget was moved by a routine 10. resume processing routine where MOVE was encountered ### `MOVEXY` Widget from HolderA 1. MOVEXY encounted moving Widget 2. change Widget properties based on HolderA.`childrenPerOwner` and HolderA.`onLeave` 3. call HolderA.`leaveRoutine` with flag indicating that widget was moved by a routine 4. Widget.`parent` set to null 5. set Widget position 6. resolve piles 7. call HolderA.`afterLeaveRoutine` with flag indicating that widget was moved by a routine 11. resume processing routine where MOVEXY was encountered ### `MOVE` Widget to HolderB (after collection support is added for MOVE) 1. MOVE encounted moving Widget 4. Widget.`parent` set to HolderB.`id` 5. change Widget properties based on HolderB.`childrenPerOwner`, HolderB.`onEnter` 6. position Widget in holder regardless of HolderB.`alignChildren` 7. resolve piles 9. call HolderB.`enterRoutine` with flag indicating that widget was moved by a routine 10. resume processing routine where MOVE was encountered
deekerman commented 2026-02-20 10:18:21 -05:00
Author
Owner
Copy link

@96LawDawg commented on GitHub (May 14, 2022):

Wow. That is an impressive amount of thought and work on the structure. Other than rooms with hacky workarounds for leaveRoutine firing twice, do you think this will break anything? I'm not sure I have the capacity to follow or understand the consequences.

@96LawDawg commented on GitHub (May 14, 2022): Wow. That is an impressive amount of thought and work on the structure. Other than rooms with hacky workarounds for `leaveRoutine` firing twice, do you think this will break anything? I'm not sure I have the capacity to follow or understand the consequences.
deekerman commented 2026-02-20 10:18:21 -05:00
Author
Owner
Copy link

@mousewax commented on GitHub (May 14, 2022):

Is this an appropriate place to add my wish list item for "showMouseCursor": false specifically for holders?

@mousewax commented on GitHub (May 14, 2022): Is this an appropriate place to add my wish list item for `"showMouseCursor": false` specifically for holders?
deekerman commented 2026-02-20 10:18:21 -05:00
Author
Owner
Copy link

@robartsd commented on GitHub (May 15, 2022):

I'm not sure I have the capacity to follow or understand the consequences.

Me either. I just was thinking enough about this that I thought it warranted a record here. I don't have significant ideas on how it to implement or what the ramifications it could have on existing games.

@robartsd commented on GitHub (May 15, 2022): > I'm not sure I have the capacity to follow or understand the consequences. Me either. I just was thinking enough about this that I thought it warranted a record here. I don't have significant ideas on how it to implement or what the ramifications it could have on existing games.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
PL-add-TooManyRoads
dependabot/npm_and_yarn/qs-6.14.2
dependabot/npm_and_yarn/multi-ca49cfd856
dependabot/npm_and_yarn/lodash-4.17.23
feature-tighterConnectionMonitoring
expand-widget-edito
fixes-in-progress-game-title
Consistent-star-icon
feature-filesPanel
feature-add-holderCopyWidget
fix/2552-editor-prefills-routine-parameters
feature-contextPopup
dependabot/npm_and_yarn/node-minify/html-minifier-10.1.1
dependabot/npm_and_yarn/node-minify/uglify-es-10.1.1
feature-assetAlias
feature-freeGames
feature-smartHolder
feature-smarterDragButtons
dependabot/npm_and_yarn/dompurify-3.3.1
feature-userAuthentication
dependabot/npm_and_yarn/body-parser-2.2.1
feature-animate-card-flips
feature-animateCardFlips
feature-PrettierGuestNames
dependabot/npm_and_yarn/js-yaml-3.14.2
feature-surfaceClass
update-card-widgets
feat-widget-tabs-221Pw
feature-ZOOMfunction
fix-addCardsButtonValues
feature-panZoomEditMode
feature-feature-fixDoubleLeaveRoutine
feature-mobileZoom
feature-desktopZoom
feature-fixTestcafeNumSort
feature-playerSpecificInputModal
feature-controlWithoutDragging
feature-fixShowingHiddenWidgetsWithoutJSON
feature-add-regexLabel
feature-add-cardLabel
legacy-compute-modes
feature-zoomy
feature-contextmenu
feature-sixteenByNine
feature-add-stackOffsetAuto
feature-routineEditor
feature-change-quickSaveLocalTime
fix-crashWhenSetToSelf
feature-lockRoom
feature-underCursor
feature-fixTurnDuplicateIndex
feature-add-timerAlertSound
bjalder26-Update-AUDIO-Tutorial
feature-updateOwnerOnRename
feature-workaroundTestcafe
bjalder26-shuffle
feature-timerSound
feature-editUIlayout
PL-update-GuanDan
bjalder26-label-text-update-JSON-editor
bugfix-recursive-CALL
fix-recursiveCALL
feature-smartClone
readmeVideoTests
codespaces
feature-reverseDropTarget
feature-fixPropertyOfArray
fix-pcioImport-moveAll
feature-cachingGet
cursor-player-name
feature-fixTTSimporter
feature-newSeatStyle
feature-fixIfComplaint
feature-feature-returnTurnTarget2
feature-canvasBrushSize
feature-recallOnlyIfNotAlreadyThere
Switch-to-Roboto-Flex
Update-Functions-Inputs
feature-emojiExtension
feature-progressiveWebApp
feature-iOSfullscreenTest
feature-iOSgestureTest
spinner-customization
feature-updateDependencies2
optimize-dom-modifications
feature-arrowKeys
combining-symbols-with-roboto-font
feature-childrenCounterRotate
feature-moveFromSeat
adjust-number-buttons-in-json-editor-to-stop-misclicks
fantasy-wars-update
robartsd/moveToHolder
robartsd/issue1605
feature-recallStuff
widget-dom
css-selector-properties
fix-scrollableLabel
feature-mtgImport
feature-betterReconnect
bjalder26-Break-Function
feature-funWithTrains
feature-splitEdit
feature-fixAssetMigration
public-library-test-PR
editable_tables
test_width
Alphabetical-mistake
feature-jsonEditorBuffer
demo-gameCategories
feature-limitRecursion
recall-optimization
JSON_fix_material
symbols-tag
JSON_move_global_commands
yet-another-game-pieces-PR
demo-stateDetailsSidebar
Holder-dropTarget-highlight
canvas-layer
fix-1116
demo-newGameListSidebar
new-game-piece-assets
demo-newGameListTutorials
feature-updateDependencies
feature-assetBatchUpload
feature-fixSafariScroll
feature-changeSortByCommand
hoverTarget-dist
ArnoldSmith86/issue1072
bjalder26-dropLimit-&-enterRoutine
feature-newGameList
feature-fixStringifiedCollection
ios-volume-fix
feature-parser
bjalder26-numericSort
feature-fixActiveFace
Text-for-holders
bjalder26-textarea-size
Major-UI-Overhaul-Project
feature-fixGameEdit
mousewax-Input-Overlay-Revamp
feature-dropTargetCSS
feature-hover
feature-dropTargetCustomization
color-to-general-widgets
Holder-customization
feature-stop
onHover-for-seats
pile-customization
fix-removedebug
bjalder26-HTML-labels
fix-label-textarea
feature-inRelation
feature-pcioRecall
feature-arrayAssignmentDeepCopy
feature-betterIDs
fonts-pr
bjalder26-JSON-editor-brackets-and-wavy-brackets
bjalder26-Test-Room
bjalder26-Click-4-Test-Room
staging-20210717
feature-MOVEcollections
feature-PCIOcimport
hide-pile-handle
New-assets-list
staging-20210710
feature-fixLeaveRoutine
bjalder26-RichText
staging-20210703
robartsd-inRelaton
legacy-compute-mode-test
stage-seat
staging-20210626
feature-absoluteCoords
staging-20210619
staging-20210612
feature-inheritFrom
random-color-to-players
feature-fixCopyPaste
adds-turn
add-in-to-computation-list
legacyVersion-2
Comments
feature-IFwithDefaultConditionVar
feature-deckManifests
legacyVersion-1
feature-sortSelect
feature-applyVariablesOperations
feature-fixGoButton
enlarge+
feature-pilesAsUI
feature-fixMoveOrder
No results found.
Labels
Clear labels   
PCIO compatibility

   
Validator

   
automated testing

   
bug

   
documentation

   
duplicate

   
editor

   
enhancement

   
enhancement

   
library

   
library

   
maintenance

   
needs legacy server

   
pile related

   
reported client crash

   
routine operations

   
user interface

   
widget properties
No labels
PCIO compatibility
Validator
automated testing
bug
documentation
duplicate
editor
enhancement
enhancement
library
library
maintenance
needs legacy server
pile related
reported client crash
routine operations
user interface
widget properties
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/virtualtabletop#521
No description provided.