Option to trigger property change on JSON editor #615

Open
opened 2026-02-20 10:19:10 -05:00 by deekerman · 4 comments
Owner

Originally created by @RaphaelAlvez on GitHub (Dec 12, 2022).

I needed this yesterday for testing some stuff

Not sure if it should be a toggle button or a new type of input. Probably the later.

For example changing the stack offset in holder does not update the holder properly

Originally created by @RaphaelAlvez on GitHub (Dec 12, 2022). I needed this yesterday for testing some stuff Not sure if it should be a toggle button or a new type of input. Probably the later. For example changing the stack offset in holder does not update the holder properly
Author
Owner

@96LawDawg commented on GitHub (Dec 12, 2022):

In your example, do you mean it doesn't change it visibly immediately? Because if you change it and then drop a new card in the holder, doesn't it work?

@96LawDawg commented on GitHub (Dec 12, 2022): In your example, do you mean it doesn't change it visibly immediately? Because if you change it and then drop a new card in the holder, doesn't it work?
Author
Owner

@RaphaelAlvez commented on GitHub (Feb 14, 2023):

Yeah but I mean that changes using th JSON editor don't trigger any change routines so testing becomes more difficult.

@RaphaelAlvez commented on GitHub (Feb 14, 2023): Yeah but I mean that changes using th JSON editor don't trigger any change routines so testing becomes more difficult.
Author
Owner

@robartsd commented on GitHub (Feb 14, 2023):

Yeah but I mean that changes using th JSON editor don't trigger any change routines so testing becomes more difficult.

I usually just throw in a temporary button and have a routine make the change. Allows for a more repeatable test. (A button to CALL millisecondChangeRoutine was very useful for debugging routine code on a timer).

If this were enabled in the JSON editor, you could have it trigger multiple times - the widget gets updated every keystroke when typing as long as the content is still valid JSON.

@robartsd commented on GitHub (Feb 14, 2023): > Yeah but I mean that changes using th JSON editor don't trigger any change routines so testing becomes more difficult. I usually just throw in a temporary button and have a routine make the change. Allows for a more repeatable test. (A button to CALL millisecondChangeRoutine was very useful for debugging routine code on a timer). If this were enabled in the JSON editor, you could have it trigger multiple times - the widget gets updated every keystroke when typing as long as the content is still valid JSON.
Author
Owner

@robartsd commented on GitHub (Feb 14, 2023):

For example changing the stack offset in holder does not update the holder properly

I'm not even sure that changing it in a routine will update the child widgets until a new child gets added. This should probably be fixed in Holder.applyDeltaToDOM() as a separate issue.

@robartsd commented on GitHub (Feb 14, 2023): > For example changing the stack offset in holder does not update the holder properly I'm not even sure that changing it in a routine will update the child widgets until a new child gets added. This should probably be fixed in Holder.applyDeltaToDOM() as a separate issue.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/virtualtabletop#615
No description provided.