mirror of
https://github.com/ArnoldSmith86/virtualtabletop.git
synced 2026-03-02 22:57:02 -05:00
Option to trigger property change on JSON editor #615
Labels
No labels
PCIO compatibility
Validator
automated testing
bug
documentation
duplicate
editor
enhancement
enhancement
library
library
maintenance
needs legacy server
pile related
reported client crash
routine operations
user interface
widget properties
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/virtualtabletop#615
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RaphaelAlvez on GitHub (Dec 12, 2022).
I needed this yesterday for testing some stuff
Not sure if it should be a toggle button or a new type of input. Probably the later.
For example changing the stack offset in holder does not update the holder properly
@96LawDawg commented on GitHub (Dec 12, 2022):
In your example, do you mean it doesn't change it visibly immediately? Because if you change it and then drop a new card in the holder, doesn't it work?
@RaphaelAlvez commented on GitHub (Feb 14, 2023):
Yeah but I mean that changes using th JSON editor don't trigger any change routines so testing becomes more difficult.
@robartsd commented on GitHub (Feb 14, 2023):
I usually just throw in a temporary button and have a routine make the change. Allows for a more repeatable test. (A button to CALL millisecondChangeRoutine was very useful for debugging routine code on a timer).
If this were enabled in the JSON editor, you could have it trigger multiple times - the widget gets updated every keystroke when typing as long as the content is still valid JSON.
@robartsd commented on GitHub (Feb 14, 2023):
I'm not even sure that changing it in a routine will update the child widgets until a new child gets added. This should probably be fixed in Holder.applyDeltaToDOM() as a separate issue.