Inheritance doesn't update correctly during routine #727

New issue

Open

opened 2026-02-20 10:20:03 -05:00 by deekerman · 0 comments

deekerman commented

2026-02-20 10:20:03 -05:00

Owner

Originally created by @ArnoldSmith86 on GitHub (Oct 30, 2023).

Caused by #1862. Video with production on the right and old behavior on the left:

cinnamon-2023-10-30T175801+0100.webm

The button changes dropOffsetY which is inherited by the other holder. Then a MOVE moves the card which should use the new dropOffsetY. In production it never does. In the old behavior it does after using the reset button once (which removes the property and moves the card back).

Both behaviors are buggy. But the change broke Shattered Dominion which I noticed while playing:

cinnamon-2023-10-30T125245+0100.webm

Originally created by @ArnoldSmith86 on GitHub (Oct 30, 2023). Caused by #1862. Video with production on the right and old behavior on the left: [cinnamon-2023-10-30T175801+0100.webm](https://github.com/ArnoldSmith86/virtualtabletop/assets/73538315/5b6fe039-59dc-4cbd-845c-45c1a49afa03) The button changes `dropOffsetY` which is inherited by the other holder. Then a `MOVE` moves the card which should use the new `dropOffsetY`. In production it never does. In the old behavior it does after using the reset button once (which removes the property and moves the card back). Both behaviors are buggy. But the change broke Shattered Dominion which I noticed while playing: [cinnamon-2023-10-30T125245+0100.webm](https://github.com/ArnoldSmith86/virtualtabletop/assets/73538315/a09d993c-3e5d-4f2a-a1d4-c0fcb934a03c)