Recursive inheritFrom slows room to a crawl #734

New issue

Open

opened 2026-02-20 10:20:05 -05:00 by deekerman · 1 comment

deekerman commented

2026-02-20 10:20:05 -05:00

Owner

Originally created by @96LawDawg on GitHub (Nov 12, 2023).

This early copy of Naval Warfare uses a poorly designed inheritFrom structure. For example, look at the red labels at the top of each column. The second one (B) inherits from A. But then C inherits from B. And D inherits from C. And so on. The holder making up the main board also have the same problem. The room is crazy slow to load and use.

I improved the inheritFrom structure for the PL, but this copy is a demo to test any fixes that might be implemented.

Naval_Warfare Bad inheritFrom.zip

Originally created by @96LawDawg on GitHub (Nov 12, 2023). This early copy of Naval Warfare uses a poorly designed inheritFrom structure. For example, look at the red labels at the top of each column. The second one (B) inherits from A. But then C inherits from B. And D inherits from C. And so on. The holder making up the main board also have the same problem. The room is crazy slow to load and use. I improved the inheritFrom structure for the PL, but this copy is a demo to test any fixes that might be implemented. [Naval_Warfare Bad inheritFrom.zip](https://github.com/ArnoldSmith86/virtualtabletop/files/13328508/Naval_Warfare.Bad.inheritFrom.zip)

deekerman added the

bug

widget properties

labels

2026-02-20 10:20:05 -05:00

deekerman commented

2026-02-20 10:20:06 -05:00

Author

Owner

@robartsd commented on GitHub (Nov 13, 2023):

I don't think trying to improve the performance of a poor inheritFrom structure is worth looking into, but tools to help identify and fix a poor inheritFrom structure are worth considering.

@robartsd commented on GitHub (Nov 13, 2023): I don't think trying to improve the performance of a poor inheritFrom structure is worth looking into, but tools to help identify and fix a poor inheritFrom structure are worth considering.